Reland of Trigger Dangerous indicator for unsafe subresources

Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1 of https://codereview.chromium.org/2461093002/ )

Reason for revert:
Relanding: fixed uninitialized UnsafeResource::is_subframe

Original issue's description:
> Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4 id:60001 of https://codereview.chromium.org/2444383007/ )
> 
> Reason for revert:
> Breaks MSan tests:
> 
> First breaking build:
> https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/2755
> 
> Original issue's description:
> > Trigger Dangerous indicator for unsafe subresources
> >
> > Previously, the Dangerous indicator was not firing for subresources
> > flagged by Safe Browsing as unsafe. This is because marking a
> > subresource as unsafe was not triggering an omnibox update. We want to
> > trigger an omnibox update whenever a URL is marked as
> > whitelisted (either pending, meaning that an interstitial is showing, or
> > whitelisted, meaning that an interstitial has been clicked through) in
> > SafeBrowsingUIManager.
> >
> > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> > DidChangeVisibleSecurityState() (since it's no longer just SSL
> > information that can affect the omnibox security UI) and moves it to
> > WebContents so that it can be called from SafeBrowsingUIManager.
> >
> > BUG=659713
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> > Cr-Commit-Position: refs/heads/master@{#428223}
> 
> TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659713
> 
> Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
> Cr-Commit-Position: refs/heads/master@{#428520}

TBR=nparker@chromium.org,jam@chromium.org,tommycli@chromium.org
BUG=659713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

[estark, 2016-10-28 22:29:34]

Created Reland of Trigger Dangerous indicator for unsafe subresources

[estark, 2016-10-28 22:36:40]

Description was changed from

==========
Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1
of https://codereview.chromium.org/2461093002/ )

Reason for revert:
Relanding: fixed uninitialized UnsafeResource::is_subframe

Original issue's description:
> Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )
> 
> Reason for revert:
> Breaks MSan tests:
> 
> First breaking build:
>
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...
> 
> Original issue's description:
> > Trigger Dangerous indicator for unsafe subresources
> >
> > Previously, the Dangerous indicator was not firing for subresources
> > flagged by Safe Browsing as unsafe. This is because marking a
> > subresource as unsafe was not triggering an omnibox update. We want to
> > trigger an omnibox update whenever a URL is marked as
> > whitelisted (either pending, meaning that an interstitial is showing, or
> > whitelisted, meaning that an interstitial has been clicked through) in
> > SafeBrowsingUIManager.
> >
> > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> > DidChangeVisibleSecurityState() (since it's no longer just SSL
> > information that can affect the omnibox security UI) and moves it to
> > WebContents so that it can be called from SafeBrowsingUIManager.
> >
> > BUG=659713
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> > Cr-Commit-Position: refs/heads/master@{#428223}
> 
> TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659713
> 
> Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
> Cr-Commit-Position: refs/heads/master@{#428520}

TBR=nparker@chromium.org,jam@chromium.org,tommycli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659713
==========

to

==========
Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1
of https://codereview.chromium.org/2461093002/ )

Reason for revert:
Relanding: fixed uninitialized UnsafeResource::is_subframe

Original issue's description:
> Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )
> 
> Reason for revert:
> Breaks MSan tests:
> 
> First breaking build:
>
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...
> 
> Original issue's description:
> > Trigger Dangerous indicator for unsafe subresources
> >
> > Previously, the Dangerous indicator was not firing for subresources
> > flagged by Safe Browsing as unsafe. This is because marking a
> > subresource as unsafe was not triggering an omnibox update. We want to
> > trigger an omnibox update whenever a URL is marked as
> > whitelisted (either pending, meaning that an interstitial is showing, or
> > whitelisted, meaning that an interstitial has been clicked through) in
> > SafeBrowsingUIManager.
> >
> > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> > DidChangeVisibleSecurityState() (since it's no longer just SSL
> > information that can affect the omnibox security UI) and moves it to
> > WebContents so that it can be called from SafeBrowsingUIManager.
> >
> > BUG=659713
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> > Cr-Commit-Position: refs/heads/master@{#428223}
> 
> TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659713
> 
> Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
> Cr-Commit-Position: refs/heads/master@{#428520}

TBR=nparker@chromium.org,jam@chromium.org,tommycli@chromium.org
BUG=659713
==========

[estark, 2016-10-28 22:37:29]

Description was changed from

==========
Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1
of https://codereview.chromium.org/2461093002/ )

Reason for revert:
Relanding: fixed uninitialized UnsafeResource::is_subframe

Original issue's description:
> Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )
> 
> Reason for revert:
> Breaks MSan tests:
> 
> First breaking build:
>
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...
> 
> Original issue's description:
> > Trigger Dangerous indicator for unsafe subresources
> >
> > Previously, the Dangerous indicator was not firing for subresources
> > flagged by Safe Browsing as unsafe. This is because marking a
> > subresource as unsafe was not triggering an omnibox update. We want to
> > trigger an omnibox update whenever a URL is marked as
> > whitelisted (either pending, meaning that an interstitial is showing, or
> > whitelisted, meaning that an interstitial has been clicked through) in
> > SafeBrowsingUIManager.
> >
> > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> > DidChangeVisibleSecurityState() (since it's no longer just SSL
> > information that can affect the omnibox security UI) and moves it to
> > WebContents so that it can be called from SafeBrowsingUIManager.
> >
> > BUG=659713
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> > Cr-Commit-Position: refs/heads/master@{#428223}
> 
> TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659713
> 
> Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
> Cr-Commit-Position: refs/heads/master@{#428520}

TBR=nparker@chromium.org,jam@chromium.org,tommycli@chromium.org
BUG=659713
==========

to

==========
Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1
of https://codereview.chromium.org/2461093002/ )

Reason for revert:
Relanding: fixed uninitialized UnsafeResource::is_subframe

Original issue's description:
> Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )
> 
> Reason for revert:
> Breaks MSan tests:
> 
> First breaking build:
>
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...
> 
> Original issue's description:
> > Trigger Dangerous indicator for unsafe subresources
> >
> > Previously, the Dangerous indicator was not firing for subresources
> > flagged by Safe Browsing as unsafe. This is because marking a
> > subresource as unsafe was not triggering an omnibox update. We want to
> > trigger an omnibox update whenever a URL is marked as
> > whitelisted (either pending, meaning that an interstitial is showing, or
> > whitelisted, meaning that an interstitial has been clicked through) in
> > SafeBrowsingUIManager.
> >
> > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> > DidChangeVisibleSecurityState() (since it's no longer just SSL
> > information that can affect the omnibox security UI) and moves it to
> > WebContents so that it can be called from SafeBrowsingUIManager.
> >
> > BUG=659713
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> > Cr-Commit-Position: refs/heads/master@{#428223}
> 
> TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659713
> 
> Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
> Cr-Commit-Position: refs/heads/master@{#428520}

TBR=nparker@chromium.org,jam@chromium.org,tommycli@chromium.org
BUG=659713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[estark, 2016-10-28 22:37:34]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[estark, 2016-10-28 22:37:48]

Patchset #2 (id:270001) has been deleted

[commit-bot: I haz the power, 2016-10-28 22:38:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-10-28 22:41:44]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[estark, 2016-10-28 22:42:05]

Patchset #2 (id:290001) has been deleted

[commit-bot: I haz the power, 2016-10-28 22:42:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-10-28 22:44:18]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 22:44:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2016-10-28 23:02:28]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-10-28 23:02:28]

Revert broke the build so relanding this immediately,
https://codereview.chromium.org/2454393003/

[Nathan Parker, 2016-10-28 23:21:33]

lgtm

[tommycli, 2016-10-29 00:06:45]

memory fix LGTM, but you will probably need to merge so that the patch is only
that one line change.

[estark, 2016-10-29 00:12:11]

Errr, there were many revert and reland CLs in a short period of time. :)

The straight reland (with no fix) landed in
https://codereview.chromium.org/2454393003/ to unbreak the build.

The msan fix is in the CQ at https://codereview.chromium.org/2458223002/

This CL is no longer needed so I'll close it.

[estark, 2016-10-29 00:12:19]

Description was changed from

==========
Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1
of https://codereview.chromium.org/2461093002/ )

Reason for revert:
Relanding: fixed uninitialized UnsafeResource::is_subframe

Original issue's description:
> Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )
> 
> Reason for revert:
> Breaks MSan tests:
> 
> First breaking build:
>
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...
> 
> Original issue's description:
> > Trigger Dangerous indicator for unsafe subresources
> >
> > Previously, the Dangerous indicator was not firing for subresources
> > flagged by Safe Browsing as unsafe. This is because marking a
> > subresource as unsafe was not triggering an omnibox update. We want to
> > trigger an omnibox update whenever a URL is marked as
> > whitelisted (either pending, meaning that an interstitial is showing, or
> > whitelisted, meaning that an interstitial has been clicked through) in
> > SafeBrowsingUIManager.
> >
> > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> > DidChangeVisibleSecurityState() (since it's no longer just SSL
> > information that can affect the omnibox security UI) and moves it to
> > WebContents so that it can be called from SafeBrowsingUIManager.
> >
> > BUG=659713
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> > Cr-Commit-Position: refs/heads/master@{#428223}
> 
> TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659713
> 
> Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
> Cr-Commit-Position: refs/heads/master@{#428520}

TBR=nparker@chromium.org,jam@chromium.org,tommycli@chromium.org
BUG=659713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1
of https://codereview.chromium.org/2461093002/ )

Reason for revert:
Relanding: fixed uninitialized UnsafeResource::is_subframe

Original issue's description:
> Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )
> 
> Reason for revert:
> Breaks MSan tests:
> 
> First breaking build:
>
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...
> 
> Original issue's description:
> > Trigger Dangerous indicator for unsafe subresources
> >
> > Previously, the Dangerous indicator was not firing for subresources
> > flagged by Safe Browsing as unsafe. This is because marking a
> > subresource as unsafe was not triggering an omnibox update. We want to
> > trigger an omnibox update whenever a URL is marked as
> > whitelisted (either pending, meaning that an interstitial is showing, or
> > whitelisted, meaning that an interstitial has been clicked through) in
> > SafeBrowsingUIManager.
> >
> > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> > DidChangeVisibleSecurityState() (since it's no longer just SSL
> > information that can affect the omnibox security UI) and moves it to
> > WebContents so that it can be called from SafeBrowsingUIManager.
> >
> > BUG=659713
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> > Cr-Commit-Position: refs/heads/master@{#428223}
> 
> TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659713
> 
> Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
> Cr-Commit-Position: refs/heads/master@{#428520}

TBR=nparker@chromium.org,jam@chromium.org,tommycli@chromium.org
BUG=659713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========