Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3937)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc

Issue 2456383003: Reland of Trigger Dangerous indicator for unsafe subresources (Closed)
Patch Set: initialize is_subframe Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/chrome_security_state_model_client.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
index 0075bb71e936b12863f263137f12ef9fab41b9c6..48722009d0a37b9060ba2fad6fac4b3189854f30 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
@@ -1231,7 +1231,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTestWithPasswordCcSwitch,
ASSERT_NO_FATAL_FAILURE(CheckForOneHttpWarningConsoleMessage(delegate));
delegate->ClearConsoleMessages();
- // Two subsequent triggers of VisibleSSLStateChanged -- one on the
+ // Two subsequent triggers of VisibleSecurityStateChanged -- one on the
// same navigation and one on another navigation -- should only result
// in one additional console message.
contents->OnCreditCardInputShownOnHttp();
@@ -1304,7 +1304,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTest, ConsoleMessage) {
ASSERT_NO_FATAL_FAILURE(CheckForOneFutureHttpWarningConsoleMessage(delegate));
delegate->ClearConsoleMessages();
- // Two subsequent triggers of VisibleSSLStateChanged -- one on the
+ // Two subsequent triggers of VisibleSecurityStateChanged -- one on the
// same navigation and one on another navigation -- should only result
// in one additional console message.
contents->OnCreditCardInputShownOnHttp();
@@ -1375,7 +1375,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTestWithPasswordCcSwitch,
ASSERT_NO_FATAL_FAILURE(CheckForOneHttpWarningConsoleMessage(delegate));
delegate->ClearConsoleMessages();
- // Navigate the subframe and trigger VisibleSSLStateChanged
+ // Navigate the subframe and trigger VisibleSecurityStateChanged
// again. While the security level is still HTTP_SHOW_WARNING, an
// additional console message should not be logged because there was
// already a console message logged for the current main-frame
@@ -1459,7 +1459,7 @@ IN_PROC_BROWSER_TEST_F(ChromeSecurityStateModelClientTestWithPasswordCcSwitch,
ASSERT_NO_FATAL_FAILURE(CheckForOneHttpWarningConsoleMessage(delegate));
delegate->ClearConsoleMessages();
- // Navigate with pushState and trigger VisibleSSLStateChanged
+ // Navigate with pushState and trigger VisibleSecurityStateChanged
// again. While the security level is still HTTP_SHOW_WARNING, an
// additional console message should not be logged because there was
// already a console message logged for the current main-frame
« no previous file with comments | « chrome/browser/ssl/chrome_security_state_model_client.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698