Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2458223002: Initialize UnsafeResource::is_subframe (Closed)

Created:
4 years, 1 month ago by estark
Modified:
4 years, 1 month ago
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize UnsafeResource::is_subframe https://codereview.chromium.org/2444383007/ triggered msan failures because this field was not being initialized. BUG=659713 TBR=nparker@chromium.org Committed: https://crrev.com/379e8d63ac82486f3b8423fde91132cd4abb77da Cr-Commit-Position: refs/heads/master@{#428553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/safe_browsing/ui_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
estark
4 years, 1 month ago (2016-10-28 23:07:10 UTC) #2
DaleCurtis
I'd probably switch this to in-struct initialization, but lgtm if that's the general style in ...
4 years, 1 month ago (2016-10-28 23:08:40 UTC) #7
Nathan Parker
lgtm I assume this superceeds the other patch I just LGTM'd
4 years, 1 month ago (2016-10-28 23:22:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458223002/1
4 years, 1 month ago (2016-10-29 00:05:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-29 00:11:43 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 00:44:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/379e8d63ac82486f3b8423fde91132cd4abb77da
Cr-Commit-Position: refs/heads/master@{#428553}

Powered by Google App Engine
This is Rietveld 408576698