Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2456053007: Revert of [Payments] Show the icon for the typed in credit card in editor (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Payments] Show the icon for the typed in credit card in editor (patchset #4 id:240001 of https://codereview.chromium.org/2442933003/ ) Reason for revert: Cause test failure: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36746 Original issue's description: > Show the icon for the typed in credit card in editor > > BUG=657178 > > Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5 > Cr-Commit-Position: refs/heads/master@{#428359} TBR=rouslan@chromium.org,mathp@chromium.org,dfalcantara@chromium.org,gogerald@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657178 Committed: https://crrev.com/a5177deb35cba34c1f167062584c633688a873cc Cr-Commit-Position: refs/heads/master@{#428411}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
xidachen
Created Revert of [Payments] Show the icon for the typed in credit card in editor
4 years, 1 month ago (2016-10-28 17:39:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456053007/1
4 years, 1 month ago (2016-10-28 17:40:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 17:41:08 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 17:53:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5177deb35cba34c1f167062584c633688a873cc
Cr-Commit-Position: refs/heads/master@{#428411}

Powered by Google App Engine
This is Rietveld 408576698