Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

Issue 2456053007: Revert of [Payments] Show the icon for the typed in credit card in editor (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
index c962cdb13e382efeea007577dfa7024e8e613dad..7e510b231483c784cbbb5066226326890bc01201 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
@@ -19,7 +19,6 @@
import org.chromium.chrome.browser.payments.PaymentRequestImpl.PaymentRequestServiceObserverForTest;
import org.chromium.chrome.browser.payments.ui.EditorFieldModel;
import org.chromium.chrome.browser.payments.ui.EditorFieldModel.EditorFieldValidator;
-import org.chromium.chrome.browser.payments.ui.EditorFieldModel.EditorValueIconGenerator;
import org.chromium.chrome.browser.payments.ui.EditorModel;
import org.chromium.chrome.browser.preferences.autofill.AutofillProfileBridge.DropdownKeyValue;
import org.chromium.content.browser.ContentViewCore;
@@ -114,7 +113,6 @@
private final Handler mHandler;
private final EditorFieldValidator mCardNumberValidator;
- private final EditorValueIconGenerator mCardIconGenerator;
private final AsyncTask<Void, Void, Calendar> mCalendar;
@Nullable private EditorFieldModel mIconHint;
@@ -182,22 +180,9 @@
mCardNumberValidator = new EditorFieldValidator() {
@Override
public boolean isValid(@Nullable CharSequence value) {
- return value != null
- && mAcceptedCardTypes.contains(
- PersonalDataManager.getInstance().getBasicCardPaymentType(
- value.toString(), true));
- }
- };
-
- mCardIconGenerator = new EditorValueIconGenerator() {
- @Override
- public int getIconResourceId(@Nullable CharSequence value) {
- if (value == null) return 0;
- CardTypeInfo cardTypeInfo =
- mCardTypes.get(PersonalDataManager.getInstance().getBasicCardPaymentType(
- value.toString(), false));
- if (cardTypeInfo == null) return 0;
- return cardTypeInfo.icon;
+ return value != null && mAcceptedCardTypes.contains(
+ PersonalDataManager.getInstance().getBasicCardPaymentTypeIfValid(
+ value.toString()));
}
};
@@ -388,8 +373,8 @@
if (mNumberField == null) {
mNumberField = EditorFieldModel.createTextInput(
EditorFieldModel.INPUT_TYPE_HINT_CREDIT_CARD,
- mContext.getString(R.string.autofill_credit_card_editor_number), null,
- mCardNumberValidator, mCardIconGenerator,
+ mContext.getString(R.string.autofill_credit_card_editor_number),
+ null, mCardNumberValidator,
mContext.getString(R.string.payments_field_required_validation_message),
mContext.getString(R.string.payments_card_number_invalid_validation_message),
null);
@@ -412,9 +397,9 @@
if (mNameField == null) {
mNameField = EditorFieldModel.createTextInput(
EditorFieldModel.INPUT_TYPE_HINT_PERSON_NAME,
- mContext.getString(R.string.autofill_credit_card_editor_name), null, null, null,
- mContext.getString(R.string.payments_field_required_validation_message), null,
- null);
+ mContext.getString(R.string.autofill_credit_card_editor_name), null, null,
+ mContext.getString(R.string.payments_field_required_validation_message),
+ null, null);
}
mNameField.setValue(card.getName());
editor.addField(mNameField);

Powered by Google App Engine
This is Rietveld 408576698