chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java - Issue 2456053007: Revert of [Payments] Show the icon for the typed in credit card in editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

Issue 2456053007: Revert of [Payments] Show the icon for the typed in credit card in editor (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/payments_request_editor_textview.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

index 74097bfb7dbe178ed8b99e8f1234747db448999b..9e364fe0043955f96467ba42c699062c62ba7b26 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

@@ -635,10 +635,9 @@

mPersonalDataManagerAndroid, cardServerId, billingAddressId);

}

- public String getBasicCardPaymentType(String cardNumber, boolean emptyIfInvalid) {

- ThreadUtils.assertOnUiThread();

- return nativeGetBasicCardPaymentType(

- mPersonalDataManagerAndroid, cardNumber, emptyIfInvalid);

+ public String getBasicCardPaymentTypeIfValid(String cardNumber) {

+ ThreadUtils.assertOnUiThread();

+ return nativeGetBasicCardPaymentTypeIfValid(mPersonalDataManagerAndroid, cardNumber);

}

@VisibleForTesting

@@ -843,8 +842,8 @@

CreditCard card);

private native void nativeUpdateServerCardBillingAddress(long nativePersonalDataManagerAndroid,

String guid, String billingAddressId);

- private native String nativeGetBasicCardPaymentType(

- long nativePersonalDataManagerAndroid, String cardNumber, boolean emptyIfInvalid);

+ private native String nativeGetBasicCardPaymentTypeIfValid(

+ long nativePersonalDataManagerAndroid, String cardNumber);

private native void nativeAddServerCreditCardForTest(long nativePersonalDataManagerAndroid,

CreditCard card);

private native void nativeRemoveByGUID(long nativePersonalDataManagerAndroid, String guid);