Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 2456053007: Revert of [Payments] Show the icon for the typed in credit card in editor (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index 6cd7eda581cce6be3354e6f47d9a2f3bfe6f46df..f71b114e14e5a8bc69fe86b4feb2da772b05afc0 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -492,21 +492,18 @@
personal_data_manager_->UpdateServerCardBillingAddress(card);
}
-ScopedJavaLocalRef<jstring> PersonalDataManagerAndroid::GetBasicCardPaymentType(
- JNIEnv* env,
- const JavaParamRef<jobject>& unused_obj,
- const JavaParamRef<jstring>& jcard_number,
- const jboolean jempty_if_invalid) {
+ScopedJavaLocalRef<jstring>
+PersonalDataManagerAndroid::GetBasicCardPaymentTypeIfValid(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& unused_obj,
+ const JavaParamRef<jstring>& jcard_number) {
base::string16 card_number = ConvertJavaStringToUTF16(env, jcard_number);
-
- if (static_cast<bool>(jempty_if_invalid) &&
- !IsValidCreditCardNumber(card_number)) {
- return ConvertUTF8ToJavaString(env, "");
- }
- return ConvertUTF8ToJavaString(env,
- data_util::GetPaymentRequestData(
- CreditCard::GetCreditCardType(card_number))
- .basic_card_payment_type);
+ return ConvertUTF8ToJavaString(
+ env, IsValidCreditCardNumber(card_number)
+ ? data_util::GetPaymentRequestData(
+ CreditCard::GetCreditCardType(card_number))
+ .basic_card_payment_type
+ : "");
}
void PersonalDataManagerAndroid::AddServerCreditCardForTest(
« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698