[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

BUG=660574
Committed: https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5
Cr-Commit-Position: refs/heads/master@{#428721}

[skym, 2016-10-28 22:51:57]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 22:52:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-10-28 23:06:07]

Description was changed from

==========
[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/action checks.

BUG=660574
==========

to

==========
[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

BUG=660574
==========

[skym, 2016-10-28 23:06:29]

PTAL.

[maxbogue, 2016-10-28 23:31:00]

maxbogue@chromium.org changed reviewers:
+ maxbogue@chromium.org

[maxbogue, 2016-10-28 23:31:00]

lgtm. Just gonna assume you meant to send this to me :P

https://codereview.chromium.org/2455343003/diff/20001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sync_test.cc (right):

https://codereview.chromium.org/2455343003/diff/20001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sync_test.cc:531: << ".";
Don't need no stinkin' .'s round these parts (and if you use "Couldn't" it will
all fit on one line..)

https://codereview.chromium.org/2455343003/diff/20001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sync_test.cc:557: << ".";
psh

https://codereview.chromium.org/2455343003/diff/20001/components/browser_sync...
File components/browser_sync/profile_sync_service_autofill_unittest.cc (right):

https://codereview.chromium.org/2455343003/diff/20001/components/browser_sync...
components/browser_sync/profile_sync_service_autofill_unittest.cc:851:
ASSERT_EQ(1U, entries.size());
I'm like... reasonably sure this was supposed to be sync_entries.

[commit-bot: I haz the power, 2016-10-29 00:00:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 00:00:14]

Dry run: This issue passed the CQ dry run.

[skym, 2016-10-31 15:08:19]

Updates for Max.

https://codereview.chromium.org/2455343003/diff/20001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sync_test.cc (right):

https://codereview.chromium.org/2455343003/diff/20001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sync_test.cc:531: << ".";
On 2016/10/28 23:31:00, maxbogue wrote:
> Don't need no stinkin' .'s round these parts (and if you use "Couldn't" it
will
> all fit on one line..)

Removed all << "." from this file. This fits on one line without using a
contraction, so leaving "Could not".

https://codereview.chromium.org/2455343003/diff/20001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sync_test.cc:557: << ".";
On 2016/10/28 23:31:00, maxbogue wrote:
> psh

Done.

https://codereview.chromium.org/2455343003/diff/20001/components/browser_sync...
File components/browser_sync/profile_sync_service_autofill_unittest.cc (right):

https://codereview.chromium.org/2455343003/diff/20001/components/browser_sync...
components/browser_sync/profile_sync_service_autofill_unittest.cc:851:
ASSERT_EQ(1U, entries.size());
On 2016/10/28 23:31:00, maxbogue wrote:
> I'm like... reasonably sure this was supposed to be sync_entries.

I agree, done.

[skym, 2016-10-31 15:08:22]

The CQ bit was checked by skym@chromium.org

[skym, 2016-10-31 15:08:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2455343003/#ps40001
(title: "\Updates for Max and rebase.")

[commit-bot: I haz the power, 2016-10-31 15:08:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 15:43:56]

Description was changed from

==========
[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

BUG=660574
==========

to

==========
[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

BUG=660574
==========

[commit-bot: I haz the power, 2016-10-31 15:43:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-31 15:55:57]

Description was changed from

==========
[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

BUG=660574
==========

to

==========
[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

BUG=660574

Committed: https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5
Cr-Commit-Position: refs/heads/master@{#428721}
==========

[commit-bot: I haz the power, 2016-10-31 15:55:58]

Patchset 3 (id:??) landed as
https://crrev.com/1aa7a3f17d23892053ff4dc1c0c088fd95822ed5
Cr-Commit-Position: refs/heads/master@{#428721}