Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/sync/test/integration/sync_datatype_helper.cc

Issue 2455343003: [Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks. (Closed)
Patch Set: \Updates for Max and rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_datatype_helper.cc
diff --git a/chrome/browser/sync/test/integration/sync_datatype_helper.cc b/chrome/browser/sync/test/integration/sync_datatype_helper.cc
index b6a22429c18e7281ff4bba0ad7d8b063d054e8c0..be6a44d0d9cce9a5b18056fd7688521697d93d5b 100644
--- a/chrome/browser/sync/test/integration/sync_datatype_helper.cc
+++ b/chrome/browser/sync/test/integration/sync_datatype_helper.cc
@@ -16,13 +16,13 @@ static SyncTest* test = nullptr;
namespace sync_datatype_helper {
void AssociateWithTest(SyncTest* test) {
- ASSERT_TRUE(test != nullptr) << "Cannot associate with null test.";
- ASSERT_TRUE(::test == nullptr) << "Already associated with a test.";
+ ASSERT_NE(nullptr, test) << "Cannot associate with null test.";
+ ASSERT_EQ(nullptr, ::test) << "Already associated with a test.";
::test = test;
}
SyncTest* test() {
- EXPECT_TRUE(::test != nullptr) << "Must call AssociateWithTest first.";
+ EXPECT_NE(nullptr, ::test) << "Must call AssociateWithTest first.";
return ::test;
}
« no previous file with comments | « chrome/browser/sync/test/integration/sync_auth_test.cc ('k') | chrome/browser/sync/test/integration/sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698