components/browser_sync/profile_sync_service_typed_url_unittest.cc - Issue 2455343003: [Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/profile_sync_service_typed_url_unittest.cc

Issue 2455343003: [Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks. (Closed)

Patch Set: \Updates for Max and rebase. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/browser_sync/profile_sync_service_typed_url_unittest.cc

diff --git a/components/browser_sync/profile_sync_service_typed_url_unittest.cc b/components/browser_sync/profile_sync_service_typed_url_unittest.cc

index 95421c3a75e563c501983043423cd451e616dcb6..bab7b5be9dedc715a24b50aff2f2cb3f60931c1a 100644

--- a/components/browser_sync/profile_sync_service_typed_url_unittest.cc

+++ b/components/browser_sync/profile_sync_service_typed_url_unittest.cc

@@ -512,7 +512,7 @@ TEST_F(ProfileSyncServiceTypedUrlTest, HasNativeHasSyncNoMerge) {

history::URLRows new_sync_entries;

GetTypedUrlsFromSyncDB(&new_sync_entries);

- EXPECT_TRUE(new_sync_entries.size() == expected.size());

+ EXPECT_EQ(expected.size(), new_sync_entries.size());

for (history::URLRows::iterator entry = new_sync_entries.begin();

entry != new_sync_entries.end(); ++entry) {

EXPECT_TRUE(URLsEqual(expected[entry->url().spec()], *entry));