Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9315)

Unified Diff: chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

Issue 2455343003: [Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks. (Closed)
Patch Set: \Updates for Max and rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc b/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
index 87a39182747b709ed16404eeb62f4ad11541d9ba..746f213ec9d71b8c914e70f1554a4b12bf4be5e7 100644
--- a/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
+++ b/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
@@ -134,7 +134,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, Sanity) {
const BookmarkNode* bar = GetBookmarkBarNode(kSingleProfileIndex);
const BookmarkNode* cnn = AddURL(
kSingleProfileIndex, bar, 0, "CNN", GURL("http://www.cnn.com"));
- ASSERT_TRUE(cnn != nullptr);
+ ASSERT_NE(nullptr, cnn);
Move(kSingleProfileIndex, tier1_a, bar, 1);
// Wait for the bookmark position change to sync.
@@ -160,12 +160,12 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, Sanity) {
const BookmarkNode* boa = AddURL(
kSingleProfileIndex, bar, bar->child_count(),
"Bank of America", GURL("https://www.bankofamerica.com"));
- ASSERT_TRUE(boa != nullptr);
+ ASSERT_NE(nullptr, boa);
Move(kSingleProfileIndex, tier1_a_url0, top, top->child_count());
const BookmarkNode* bubble = AddURL(
kSingleProfileIndex, bar, bar->child_count(), "Seattle Bubble",
GURL("http://seattlebubble.com"));
- ASSERT_TRUE(bubble != nullptr);
+ ASSERT_NE(nullptr, bubble);
const BookmarkNode* wired = AddURL(
kSingleProfileIndex, bar, 2, "Wired News", GURL("http://www.wired.com"));
const BookmarkNode* tier2_b = AddFolder(
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698