Reduce usage of VisibleSelection::setBase() and setExtent()

Reduce usage of VisibleSelection::setBase() and setExtent()

This patch changes call sites of |VisibleSelection::setBase()| and |setExtent()|
by returning new |VisibleSelection| object as preparation of making
|VisibleSelection| to immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes

Committed: https://crrev.com/6467f6800bed03a444a4f9453977c06bb4591728
Cr-Commit-Position: refs/heads/master@{#428659}

[yosin_UTC9, 2016-10-28 09:32:45]

Description was changed from

==========
2016-10-28T18:21:08

BUG=
==========

to

==========
Get rid of VisbileSelection::setBase() and setExtent()

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-28 09:33:31]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 09:33:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 09:49:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 09:49:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2016-10-31 01:55:35]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 01:55:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 03:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 03:05:28]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-31 04:57:12]

Description was changed from

==========
Get rid of VisbileSelection::setBase() and setExtent()

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Reduce usage of VisibleSelection::setBase() and setExtent()

This patch changes call sites of |VisibleSelection::setBase()| and |setExtent()|
by returning new |VisibleSelection| object as preparation of making
|VisibleSelection| to immutable.

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-31 04:57:30]

Description was changed from

==========
Reduce usage of VisibleSelection::setBase() and setExtent()

This patch changes call sites of |VisibleSelection::setBase()| and |setExtent()|
by returning new |VisibleSelection| object as preparation of making
|VisibleSelection| to immutable.

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Reduce usage of VisibleSelection::setBase() and setExtent()

This patch changes call sites of |VisibleSelection::setBase()| and |setExtent()|
by returning new |VisibleSelection| object as preparation of making
|VisibleSelection| to immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-31 04:57:46]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-31 04:57:46]

PTAL

[Xiaocheng, 2016-10-31 05:38:39]

lgtm

[yosin_UTC9, 2016-10-31 06:11:06]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-31 06:11:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 06:17:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-31 06:21:02]

Description was changed from

==========
Reduce usage of VisibleSelection::setBase() and setExtent()

This patch changes call sites of |VisibleSelection::setBase()| and |setExtent()|
by returning new |VisibleSelection| object as preparation of making
|VisibleSelection| to immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Reduce usage of VisibleSelection::setBase() and setExtent()

This patch changes call sites of |VisibleSelection::setBase()| and |setExtent()|
by returning new |VisibleSelection| object as preparation of making
|VisibleSelection| to immutable for improving code health.

BUG=660320
TEST=n/a; no behavior changes

Committed: https://crrev.com/6467f6800bed03a444a4f9453977c06bb4591728
Cr-Commit-Position: refs/heads/master@{#428659}
==========

[commit-bot: I haz the power, 2016-10-31 06:21:03]

Patchset 3 (id:??) landed as
https://crrev.com/6467f6800bed03a444a4f9453977c06bb4591728
Cr-Commit-Position: refs/heads/master@{#428659}