Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2455083003: Reduce usage of VisibleSelection::setBase() and setExtent() (Closed)
Patch Set: 2016-10-31T10:31:10 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index 2a8aa7d5a4e2f73b4e1a5953999c30433e7bf437..02286e4175cf24b0a43183241625f44a446698c9 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -83,15 +83,15 @@ VisibleSelectionInFlatTree expandSelectionToRespectUserSelectAll(
if (!rootUserSelectAll)
return selection;
- VisibleSelectionInFlatTree newSelection(selection);
- newSelection.setBase(mostBackwardCaretPosition(
- PositionInFlatTree::beforeNode(rootUserSelectAll),
- CanCrossEditingBoundary));
- newSelection.setExtent(
- mostForwardCaretPosition(PositionInFlatTree::afterNode(rootUserSelectAll),
- CanCrossEditingBoundary));
-
- return newSelection;
+ return createVisibleSelection(
+ SelectionInFlatTree::Builder(selection.asSelection())
+ .collapse(mostBackwardCaretPosition(
+ PositionInFlatTree::beforeNode(rootUserSelectAll),
+ CanCrossEditingBoundary))
+ .extend(mostForwardCaretPosition(
+ PositionInFlatTree::afterNode(rootUserSelectAll),
+ CanCrossEditingBoundary))
+ .build());
}
static int textDistance(const PositionInFlatTree& start,

Powered by Google App Engine
This is Rietveld 408576698