Reduce usage of VisibleSelection::setBase() and setExtent()

third_party/WebKit/Source/core/editing/SelectionController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 65 matching lines @@
 }
 
 VisibleSelectionInFlatTree expandSelectionToRespectUserSelectAll(
     Node* targetNode,
     const VisibleSelectionInFlatTree& selection) {
   Node* const rootUserSelectAll =
       EditingInFlatTreeStrategy::rootUserSelectAllForNode(targetNode);
   if (!rootUserSelectAll)
     return selection;
 
-  VisibleSelectionInFlatTree newSelection(selection);
-  newSelection.setBase(mostBackwardCaretPosition(
-      PositionInFlatTree::beforeNode(rootUserSelectAll),
-      CanCrossEditingBoundary));
-  newSelection.setExtent(
-      mostForwardCaretPosition(PositionInFlatTree::afterNode(rootUserSelectAll),
-                               CanCrossEditingBoundary));
-
-  return newSelection;
+  return createVisibleSelection(
+      SelectionInFlatTree::Builder(selection.asSelection())
+          .collapse(mostBackwardCaretPosition(
+              PositionInFlatTree::beforeNode(rootUserSelectAll),
+              CanCrossEditingBoundary))
+          .extend(mostForwardCaretPosition(
+              PositionInFlatTree::afterNode(rootUserSelectAll),
+              CanCrossEditingBoundary))
+          .build());
 }
 
 static int textDistance(const PositionInFlatTree& start,
                         const PositionInFlatTree& end) {
   return TextIteratorInFlatTree::rangeLength(start, end, true);
 }
 
 bool canMouseDownStartSelect(Node* node) {
   if (!node || !node->layoutObject())
     return true;
@@ skipping 860 matching lines @@
   return event.event().altKey() && event.isOverLink();
 }
 
 bool isExtendingSelection(const MouseEventWithHitTestResults& event) {
   bool isMouseDownOnLinkOrImage =
       event.isOverLink() || event.hitTestResult().image();
   return event.event().shiftKey() && !isMouseDownOnLinkOrImage;
 }
 
 }  // namespace blink