third_party/WebKit/Source/core/editing/VisibleSelection.h - Issue 2455083003: Reduce usage of VisibleSelection::setBase() and setExtent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2455083003: Reduce usage of VisibleSelection::setBase() and setExtent() (Closed)

Patch Set: 2016-10-31T10:31:10 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelection.h

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h

index 55b88264368ff0b13af9705a50e7a2698c063400..16b18f0baf1293ef1c10ed391548aabe55f519cc 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h

@@ -75,6 +75,7 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {

void setExtent(const PositionTemplate<Strategy>&);

void setExtent(const VisiblePositionTemplate<Strategy>&);

+ SelectionTemplate<Strategy> asSelection() const;

PositionTemplate<Strategy> base() const { return m_base; }

PositionTemplate<Strategy> extent() const { return m_extent; }

PositionTemplate<Strategy> start() const { return m_start; }