Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2453663002: Remove complexity from the input pipeline. (Closed)

Created:
4 years, 1 month ago by dtapuska
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove complexity from the input pipeline. Mouse Move events are sent right away. Remove the acking behaviour devtools implemented to get around the single mouse move event outstanding. This code is unnecessary now. BUG=615090, 659289 Committed: https://crrev.com/c946754cb3f792ed4f5cc51ec3ba468442130359 Cr-Commit-Position: refs/heads/master@{#427790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -67 lines) Patch
M content/renderer/devtools/devtools_agent.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.h View 2 chunks +0 lines, -12 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 5 chunks +3 lines, -29 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
dtapuska
dgozman@chromium.org: Please review changes in creis@chromium.org: Please review changes in
4 years, 1 month ago (2016-10-26 01:50:05 UTC) #4
tdresser
LGTM
4 years, 1 month ago (2016-10-26 13:27:53 UTC) #7
dgozman
lgtm. Please attribute to bug 659289 as well.
4 years, 1 month ago (2016-10-26 17:44:35 UTC) #8
Charlie Reis
RS LGTM for content/
4 years, 1 month ago (2016-10-26 18:32:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453663002/1
4 years, 1 month ago (2016-10-26 18:40:30 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 21:12:16 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:15:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c946754cb3f792ed4f5cc51ec3ba468442130359
Cr-Commit-Position: refs/heads/master@{#427790}

Powered by Google App Engine
This is Rietveld 408576698