Remove complexity from the input pipeline.

content/renderer/input/render_widget_input_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/input/render_widget_input_handler.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 
@@ skipping 162 matching lines @@
 
 RenderWidgetInputHandler::RenderWidgetInputHandler(
     RenderWidgetInputHandlerDelegate* delegate,
     RenderWidget* widget)
     : delegate_(delegate),
       widget_(widget),
       handling_input_event_(false),
       handling_event_overscroll_(nullptr),
       handling_event_type_(WebInputEvent::Undefined),
       context_menu_source_type_(ui::MENU_SOURCE_MOUSE),
-      suppress_next_char_events_(false),
-      ignore_ack_for_mouse_move_from_debugger_(false) {
+      suppress_next_char_events_(false) {
   DCHECK(delegate);
   DCHECK(widget);
   delegate->SetInputHandler(this);
 }
 
 RenderWidgetInputHandler::~RenderWidgetInputHandler() {}
 
 void RenderWidgetInputHandler::HandleInputEvent(
     const WebInputEvent& input_event,
     const ui::LatencyInfo& latency_info,
@@ skipping 195 matching lines @@
       delegate_->ObserveGestureEventAndResult(
           gesture_event,
           event_overscroll ? event_overscroll->latest_overscroll_delta
                            : gfx::Vector2dF(),
           processed != WebInputEventResult::NotHandled);
     }
   }
 
   TRACE_EVENT_SYNTHETIC_DELAY_END("blink.HandleInputEvent");
 
-  // Note that we can't use handling_event_type_ here since it will be
-  // overridden by reentrant calls for events after the paused one.
-  bool can_send_ack = !(ignore_ack_for_mouse_move_from_debugger_ &&
-                        input_event.type == WebInputEvent::MouseMove);
   if (dispatch_type == DISPATCH_TYPE_BLOCKING_NOTIFY_MAIN) {
     // |non_blocking| means it was ack'd already by the InputHandlerProxy
     // so let the delegate know the event has been handled.
     delegate_->NotifyInputEventHandled(input_event.type, ack_result);
   }
 
   if ((dispatch_type == DISPATCH_TYPE_BLOCKING ||
-       dispatch_type == DISPATCH_TYPE_BLOCKING_NOTIFY_MAIN) &&
-      can_send_ack) {
+       dispatch_type == DISPATCH_TYPE_BLOCKING_NOTIFY_MAIN)) {
     std::unique_ptr<InputEventAck> response(new InputEventAck(
         input_event.type, ack_result, swap_latency_info,
         std::move(event_overscroll),
         ui::WebInputEventTraits::GetUniqueTouchEventId(input_event)));
     delegate_->OnInputEventAck(std::move(response));
   } else {
     DCHECK(!event_overscroll) << "Unexpected overscroll for un-acked event";
   }
-  if (can_send_ack && RenderThreadImpl::current()) {
+  if (RenderThreadImpl::current()) {
     RenderThreadImpl::current()
         ->GetRendererScheduler()
         ->DidHandleInputEventOnMainThread(input_event);
   }
-  if (input_event.type == WebInputEvent::MouseMove)
-    ignore_ack_for_mouse_move_from_debugger_ = false;
 
 #if defined(OS_ANDROID)
   // Allow the IME to be shown when the focus changes as a consequence
   // of a processed touch end event.
   if (input_event.type == WebInputEvent::TouchEnd &&
       processed != WebInputEventResult::NotHandled) {
     delegate_->UpdateTextInputState(ShowIme::IF_NEEDED,
                                     ChangeSource::FROM_NON_IME);
   }
 #elif defined(USE_AURA)
@@ skipping 38 matching lines @@
   // If we're currently handling an event, stash the overscroll data such that
   // it can be bundled in the event ack.
   if (handling_event_overscroll_) {
     *handling_event_overscroll_ = std::move(params);
     return;
   }
 
   delegate_->OnDidOverscroll(*params);
 }
 
-bool RenderWidgetInputHandler::SendAckForMouseMoveFromDebugger() {
-  if (handling_event_type_ == WebInputEvent::MouseMove) {
-    // If we pause multiple times during a single mouse move event, we should
-    // only send ACK once.
-    if (!ignore_ack_for_mouse_move_from_debugger_) {
-      std::unique_ptr<InputEventAck> ack(new InputEventAck(
-          handling_event_type_, INPUT_EVENT_ACK_STATE_CONSUMED));
-      delegate_->OnInputEventAck(std::move(ack));
-      return true;
-    }
-  }
-  return false;
-}
-
-void RenderWidgetInputHandler::IgnoreAckForMouseMoveFromDebugger() {
-  ignore_ack_for_mouse_move_from_debugger_ = true;
-}
-
 }  // namespace content