Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2448593002: Remove SkAutoTUnref and SkAutoTDelete from public includes. (Closed)

Created:
4 years, 1 month ago by bungeman-skia
Modified:
4 years, 1 month ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkAutoTUnref and SkAutoTDelete from public includes. This also makes the required changed to src, tests, and tools. The few public APIs modified by this change appear to be unused outside of Skia. Removing these from the public API makes it easier to ensure users are no longer using them. This also updates GrGpu::wrapBackendXXX and the ::onWrapBackendXXX methods to clarify ownership. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2448593002 Committed: https://skia.googlesource.com/skia/+/6bd5284415bd983b0628c4941dff5def40018f5a

Patch Set 1 #

Patch Set 2 : Fix refcnt misunderstanding. #

Patch Set 3 : Print out failure. #

Patch Set 4 : Keep extension list sorted. #

Patch Set 5 : And Vulcan. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -355 lines) Patch
M dm/DMSrcSink.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gm/deferredtextureimage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/image_pict.cpp View 1 2 2 chunks +10 lines, -9 lines 0 comments Download
M include/codec/SkAndroidCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M include/codec/SkCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkCanvas.h View 3 chunks +2 lines, -8 lines 0 comments Download
M include/core/SkPath.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPathRef.h View 4 chunks +5 lines, -5 lines 0 comments Download
M include/core/SkPictureRecorder.h View 1 chunk +7 lines, -7 lines 0 comments Download
M include/core/SkWriteBuffer.h View 2 chunks +3 lines, -5 lines 0 comments Download
M include/gpu/GrCaps.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 5 chunks +9 lines, -9 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrGpuResourceRef.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrTextureProvider.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M include/gpu/gl/GrGLExtensions.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/vk/GrVkBackendContext.h View 1 chunk +9 lines, -9 lines 0 comments Download
M include/ports/SkFontMgr_indirect.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/ports/SkTypeface_win.h View 1 chunk +1 line, -1 line 0 comments Download
M include/private/GrAuditTrail.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/private/SkMiniRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M include/views/SkOSWindow_Win.h View 1 chunk +5 lines, -5 lines 0 comments Download
M include/xml/SkDOM.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M src/core/SkMaskGamma.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPathRef.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureRecorder.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M src/core/SkRecordedDrawable.h View 2 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkRecordedDrawable.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkWriteBuffer.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/GrAuditTrail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrContextPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrRenderTargetOpList.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLExtensions.cpp View 1 2 3 3 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 chunks +9 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLTextureRenderTarget.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLTextureRenderTarget.cpp View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 2 3 4 2 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 2 3 4 3 chunks +10 lines, -20 lines 0 comments Download
M src/gpu/vk/GrVkRenderTarget.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkRenderTarget.cpp View 1 2 3 4 2 chunks +7 lines, -8 lines 0 comments Download
M src/gpu/vk/GrVkTexture.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkTexture.cpp View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkTextureRenderTarget.h View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkTextureRenderTarget.cpp View 1 2 3 4 2 chunks +6 lines, -8 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 2 8 chunks +17 lines, -17 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/utils/SkDeferredCanvas.h View 1 chunk +0 lines, -1 line 0 comments Download
M tests/EGLImageTest.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M tests/GrSurfaceTest.cpp View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M tests/ImageTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/PathTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RectangleTextureTest.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M tests/VkWrapTests.cpp View 1 2 3 4 6 chunks +3 lines, -9 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M tools/gpu/vk/VkTestContext.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (23 generated)
bungeman-skia
4 years, 1 month ago (2016-10-27 15:23:16 UTC) #20
reed1
lgtm
4 years, 1 month ago (2016-10-27 15:56:09 UTC) #23
bsalomon
lgtm
4 years, 1 month ago (2016-10-27 16:27:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448593002/80001
4 years, 1 month ago (2016-10-27 16:28:41 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:30:12 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6bd5284415bd983b0628c4941dff5def40018f5a

Powered by Google App Engine
This is Rietveld 408576698