Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2447773003: Use a const reference in IntentPickerResponse (Closed)

Created:
4 years, 1 month ago by Yusuke Sato
Modified:
4 years, 1 month ago
Reviewers:
sky, djacobo_
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a const reference in IntentPickerResponse Also remove an extra 'explicit' qualifier in arc/. BUG=None TEST=try Committed: https://crrev.com/4fed1185c0b9ef9d1f0b02b0fb5718bf05a9212e Cr-Commit-Position: refs/heads/master@{#427150}

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_navigation_throttle.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_navigation_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/intent_picker_bubble_view_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Yusuke Sato
PTAL
4 years, 1 month ago (2016-10-24 17:35:04 UTC) #4
djacobo_
LGTM , thanks!
4 years, 1 month ago (2016-10-24 18:20:53 UTC) #7
Yusuke Sato
+sky Could you do an owner review for c/b/ui/?
4 years, 1 month ago (2016-10-24 19:23:15 UTC) #9
sky
LGTM
4 years, 1 month ago (2016-10-24 20:53:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447773003/20001
4 years, 1 month ago (2016-10-24 20:54:58 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 21:12:19 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 21:14:36 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4fed1185c0b9ef9d1f0b02b0fb5718bf05a9212e
Cr-Commit-Position: refs/heads/master@{#427150}

Powered by Google App Engine
This is Rietveld 408576698