chrome/browser/chromeos/arc/arc_navigation_throttle.cc - Issue 2447773003: Use a const reference in IntentPickerResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_navigation_throttle.cc

Issue 2447773003: Use a const reference in IntentPickerResponse (Closed)

Patch Set: fix tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_navigation_throttle.cc

diff --git a/chrome/browser/chromeos/arc/arc_navigation_throttle.cc b/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

index 59367ca1ba537de42b6ba621933a72656e045a7c..9518b3112ce0ed6fe8b3dde47072097894a8652b 100644

--- a/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

+++ b/chrome/browser/chromeos/arc/arc_navigation_throttle.cc

@@ -248,7 +248,7 @@ void ArcNavigationThrottle::OnAppIconsReceived(

void ArcNavigationThrottle::OnIntentPickerClosed(

mojo::Array<mojom::IntentHandlerInfoPtr> handlers,

- std::string selected_app_package,

+ const std::string& selected_app_package,

CloseReason close_reason) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

const GURL& url = navigation_handle()->GetURL();