Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/ui/browser_dialogs.h

Issue 2447773003: Use a const reference in IntentPickerResponse (Closed)
Patch Set: fix tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
6 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 6 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 } // namespace chrome 173 } // namespace chrome
174 174
175 #if defined(OS_CHROMEOS) 175 #if defined(OS_CHROMEOS)
176 176
177 // This callback informs the package name of the app selected by the user, along 177 // This callback informs the package name of the app selected by the user, along
178 // with the reason why the Bubble was closed. The string param must have a valid 178 // with the reason why the Bubble was closed. The string param must have a valid
179 // package name, except when the CloseReason is ERROR or DIALOG_DEACTIVATED, for 179 // package name, except when the CloseReason is ERROR or DIALOG_DEACTIVATED, for
180 // these cases we return a dummy value which won't be used at all and has no 180 // these cases we return a dummy value which won't be used at all and has no
181 // significance. 181 // significance.
182 using IntentPickerResponse = 182 using IntentPickerResponse =
183 base::Callback<void(std::string, arc::ArcNavigationThrottle::CloseReason)>; 183 base::Callback<void(const std::string&,
184 arc::ArcNavigationThrottle::CloseReason)>;
184 185
185 // Return a pointer to the IntentPickerBubbleView::ShowBubble method. 186 // Return a pointer to the IntentPickerBubbleView::ShowBubble method.
186 using BubbleShowPtr = 187 using BubbleShowPtr =
187 void (*)(content::WebContents*, 188 void (*)(content::WebContents*,
188 const std::vector<arc::ArcNavigationThrottle::AppInfo>&, 189 const std::vector<arc::ArcNavigationThrottle::AppInfo>&,
189 const IntentPickerResponse&); 190 const IntentPickerResponse&);
190 191
191 BubbleShowPtr ShowIntentPickerBubble(); 192 BubbleShowPtr ShowIntentPickerBubble();
192 193
193 #endif // OS_CHROMEOS 194 #endif // OS_CHROMEOS
194 195
195 #endif // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 196 #endif // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/arc/arc_navigation_throttle.cc ('k') | chrome/browser/ui/views/intent_picker_bubble_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698