chrome/browser/ui/browser_dialogs.h - Issue 2447773003: Use a const reference in IntentPickerResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_dialogs.h

Issue 2447773003: Use a const reference in IntentPickerResponse (Closed)

Patch Set: fix tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_dialogs.h

diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h

index 0bc1b7e8700030e286936e264bc378e7b8a21eee..07c70ee199b46d73f5e1c5f34ee58a07dec4762e 100644

--- a/chrome/browser/ui/browser_dialogs.h

+++ b/chrome/browser/ui/browser_dialogs.h

@@ -180,7 +180,8 @@ class ContentSettingBubbleViewsBridge {

// these cases we return a dummy value which won't be used at all and has no

// significance.

using IntentPickerResponse =

- base::Callback<void(std::string, arc::ArcNavigationThrottle::CloseReason)>;

+ base::Callback<void(const std::string&,

+ arc::ArcNavigationThrottle::CloseReason)>;

// Return a pointer to the IntentPickerBubbleView::ShowBubble method.

using BubbleShowPtr =