Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2443063002: bluetooth: Require frame to be connected for stopNotifications to succeed. (Closed)

Created:
4 years, 1 month ago by ortuno
Modified:
4 years, 1 month ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, haraken, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, ortuno+watch_chromium.org, Peter Beverloo, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Require frame to be connected for stopNotifications to succeed. If a frame is not connected or disconnects during a stopNotifications request we reject the promise with NetworkError. Also adds a new adapter for delayed StopNotifySession callbacks. BUG=608538 Committed: https://crrev.com/7a703abc1287ff478b1bfe15bf68af7b48331740 Cr-Commit-Position: refs/heads/master@{#428655}

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Fix test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -19 lines) Patch
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 1 chunk +20 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 2 chunks +75 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-before.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-device-disconnects-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-disconnect-called-before.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/gatt-op-disconnect-called-during-success.js View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/stopNotifications/device-reconnects-during-success.html View 1 chunk +4 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/stopNotifications/gen-gatt-op-device-disconnects-before.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/stopNotifications/gen-gatt-op-device-disconnects-during-success.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/stopNotifications/gen-gatt-op-disconnect-called-before.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/stopNotifications/gen-gatt-op-disconnect-called-during-success.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/stopNotifications/reconnect-during-success.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
ortuno
4 years, 1 month ago (2016-10-28 21:31:18 UTC) #4
scheib
LGTM
4 years, 1 month ago (2016-10-29 00:17:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443063002/40001
4 years, 1 month ago (2016-10-31 03:55:46 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-31 05:06:17 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 05:08:50 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7a703abc1287ff478b1bfe15bf68af7b48331740
Cr-Commit-Position: refs/heads/master@{#428655}

Powered by Google App Engine
This is Rietveld 408576698