Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 2447593002: bluetooth: Require frame to be connected for startNotifications to succeed. (Closed)
Patch Set: Remove stopNotifications code Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 0069714f6087f3b43def661263ad26bb3cd835b2..2e0d570d66475d272115fb4f469dad2207f00d5b 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -317,9 +317,9 @@ class LayoutTestBluetoothAdapterProvider {
// - Read: Calls GattCharacteristicValueChanged and success
// callback with [1].
// - Write: Calls success callback.
+ // - StartNotifySession: Run success callback.
// - GetProperties: Returns
// BluetoothRemoteGattCharacteristic::PROPERTY_READ
- // TODO(crbug.com/608538): Mock Write and StartNotifySession.
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
GetDisconnectingHealthThermometer();
@@ -366,6 +366,10 @@ class LayoutTestBluetoothAdapterProvider {
// otherwise it saves a failing callback. This callback is run
// during CreateGattConnection. If |disconnect| is true
// disconnects the device.
+ // - StartNotifySession: If |succeeds| is true, saves a
+ // succeeding callback, otherwise it saves a failing callback.
+ // This calback is run during CreateGattConnection. If
+ // |disconnect| is true disconnects the device.
// - CreateGattConnection: Runs success callback with a new GATT
// connection and runs any pending GATT operation callbacks.
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
« no previous file with comments | « no previous file | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698