Update ICU to 58.1

Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels

BUG=637001
TEST=Layout tests, all unittests, browser tests

Committed: https://crrev.com/b2b928ac0d2e7caabffd9a10b94e71ef534b206a
Cr-Commit-Position: refs/heads/master@{#429312}

[jungshik at Google, 2016-10-23 07:40:38]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 07:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 07:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 07:43:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jungshik at Google, 2016-10-23 08:06:48]

Description was changed from

==========
Update ICU to 58.1 (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

 a71552ba90e2ff8bb69f07d212b2c82ec4d2798f (58staging branch in icu.git)
 has basically the same as what's in the above CL.

BUG=637001
==========

to

==========
Update ICU to 58.1 (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

 c6bee0c04a5f85e1e2949a1f83a696978adbaa08 (58staging branch in icu.git)
 has basically the same as what's in the above CL.

BUG=637001
==========

[jungshik at Google, 2016-10-23 08:07:39]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 08:07:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 08:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 08:50:28]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[jungshik at Google, 2016-10-23 10:27:34]

Description was changed from

==========
Update ICU to 58.1 (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

 c6bee0c04a5f85e1e2949a1f83a696978adbaa08 (58staging branch in icu.git)
 has basically the same as what's in the above CL.

BUG=637001
==========

to

==========
Update ICU to 58.1 (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

 90c7cc9d75836abc88d70e5f56e333dbd681329f (58staging branch in
 icu.git) is basically the same as what's in the above CL.

BUG=637001
CQ-
==========

[jungshik at Google, 2016-10-23 10:28:54]

Description was changed from

==========
Update ICU to 58.1 (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

 90c7cc9d75836abc88d70e5f56e333dbd681329f (58staging branch in
 icu.git) is basically the same as what's in the above CL.

BUG=637001
CQ-
==========

to

==========
Update ICU to 58.1 (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

 90c7cc9d75836abc88d70e5f56e333dbd681329f (58staging branch in
 icu.git) is basically the same as what's in the above CL.

BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jungshik at Google, 2016-10-23 10:29:40]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 10:29:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 11:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 11:02:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jungshik at Google, 2016-10-23 12:11:48]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-23 12:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-23 12:56:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-23 12:56:52]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jungshik at Google, 2016-10-25 23:33:46]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 23:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:17:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:17:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jungshik at Google, 2016-10-27 10:04:55]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 10:05:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 12:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 12:31:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jungshik at Google, 2016-10-27 18:29:01]

Description was changed from

==========
Update ICU to 58.1 (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

 90c7cc9d75836abc88d70e5f56e333dbd681329f (58staging branch in
 icu.git) is basically the same as what's in the above CL.

BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Update ICU to 58.1 staging (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jungshik at Google, 2016-10-27 19:10:47]

Description was changed from

==========
Update ICU to 58.1 staging (for trybots)

 This is not gonna be submitted, but just for running trybots
 because trybots do not work with
 https://codereview.chromium.org/2442923002 (ICU data files
 are not uploaded and a patch-apply step fails).

BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

For now, icu in DEPS points to 58staging branch, but will
points to ICU master once ICU master is updated from 58staging
branch.

BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

[jungshik at Google, 2016-10-28 20:01:53]

Description was changed from

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

For now, icu in DEPS points to 58staging branch, but will
points to ICU master once ICU master is updated from 58staging
branch.

BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

to

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

[jungshik at Google, 2016-10-28 20:19:33]

Description was changed from

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

to

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix the following tests:

* components_unittests:

* Layout tests



BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

[jungshik at Google, 2016-10-28 20:33:11]

Description was changed from

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix the following tests:

* components_unittests:

* Layout tests



BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

to

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels



BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

[jungshik at Google, 2016-10-28 21:41:00]

Description was changed from

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels



BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

to

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels



BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

[jungshik at Google, 2016-10-28 21:41:00]

jshin@chromium.org changed reviewers:
+ drott@chromium.org, glevin@chromium.org, jsbell@chromium.org,
pkasting@chromium.org

[jungshik at Google, 2016-10-28 22:07:23]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 22:08:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 22:08:44]

Dry run: CQ has no permission to schedule in bucket tryserver.blink

[jungshik at Google, 2016-10-28 22:09:44]

Can you take a look?

Dominik: layout test changes
Joshua: imported/wpt :  as I wrote elsewhere, I'll not land this CL until the
upstream wpt takes either my pull request or mozilla's (they're identical). 

Peter: url_formatter
Greg: Percent format test 

Thank you. :

[jsbell, 2016-10-28 22:23:36]

imported/wpt lgtm

[Peter Kasting, 2016-10-28 22:46:18]

LGTM

https://codereview.chromium.org/2447513002/diff/190001/components/url_formatt...
File components/url_formatter/url_formatter.cc (right):

https://codereview.chromium.org/2447513002/diff/190001/components/url_formatt...
components/url_formatter/url_formatter.cc:377: // Besides, disallow what used to
be blocked by mixed-script-confusable(MSC)
Nit "Besides," -> "Also"; space before '('

https://codereview.chromium.org/2447513002/diff/190001/components/url_formatt...
components/url_formatter/url_formatter.cc:396: "\\u0585.*[a-z]+|[a-z]+\\u0585",
-1, US_INV),
Note, I do not speak regex enough to really review this, assuming you did it
right + smartly

[jungshik at Google, 2016-10-31 08:48:57]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 08:49:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 08:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 08:49:24]

Dry run: CQ has no permission to schedule in bucket tryserver.blink

[Greg Levin, 2016-10-31 21:19:55]

LGTM for number_formatting_unittest.cc.

Question, though: Is this going to cause another break / discontinuity in the
bisect tool? See
   https://bugs.chromium.org/p/chromium/issues/detail?id=600740

+dmazzoni@ - Do you know if any work has been done on that issue, or if bisect
is going to break every time there's an icu update?

[jungshik at Google, 2016-10-31 22:51:51]

On 2016/10/31 21:19:55, Greg Levin wrote:
> LGTM for number_formatting_unittest.cc.
> 
> Question, though: Is this going to cause another break / discontinuity in the
> bisect tool? See
>    https://bugs.chromium.org/p/chromium/issues/detail?id=600740
> 
> +dmazzoni@ - Do you know if any work has been done on that issue, or if bisect
> is going to break every time there's an icu update?

Thank you for the pointer to the bug as well as LGTM. 

icudtl.dat should be treated like other resources (strings, images, css, html,
etc) by bisector tools. I added a comment to that effect
to the bug.

[Greg Levin, 2016-10-31 22:56:53]

On 2016/10/31 22:51:51, jungshik at google wrote:
> On 2016/10/31 21:19:55, Greg Levin wrote:
> > LGTM for number_formatting_unittest.cc.
> > 
> > Question, though: Is this going to cause another break / discontinuity in
the
> > bisect tool? See
> >    https://bugs.chromium.org/p/chromium/issues/detail?id=600740
> > 
> > +dmazzoni@ - Do you know if any work has been done on that issue, or if
bisect
> > is going to break every time there's an icu update?
> 
> Thank you for the pointer to the bug as well as LGTM. 
> 
> icudtl.dat should be treated like other resources (strings, images, css, html,
> etc) by bisector tools. I added a comment to that effect
> to the bug.

Yeah, it seems like it should, but my recollection is that that't not the case,
and it needs a local copy of the file.  I don't know much about how the bisects
work, so I don't know why.

dmazzoni@ - Any insight, or references to people who know more about this issue?

BTW, I don't personally consider this a blocker for this CL.  It broke once
before, and wasn't really fixed.  I assume everyone who figured out how to work
around it then can do so again.  But it seemed like a good time to mention it
:-)

[jungshik at Google, 2016-10-31 23:56:10]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 23:56:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:57:10]

Dry run: CQ has no permission to schedule in bucket tryserver.blink

[jungshik at Google, 2016-11-01 00:17:29]

Dominik, can you take a look at layout test changes/rebaselining? 

Peter, thank you for the review. Your comment prompted me to tighten/update
regex and tests (and comments).

[jungshik at Google, 2016-11-01 19:42:19]

To help Dominik understand what's new in new baselines, I added comments below.

https://codereview.chromium.org/2447513002/diff/210001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/platform/linux/fast/text/color-emoji-expected.txt
(right):

https://codereview.chromium.org/2447513002/diff/210001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/platform/linux/fast/text/color-emoji-expected.txt:40:
text run at (0,0) width 403: "zero-width-joiners:
\x{270C}\x{200D}\x{D83C}\x{DFFF}\x{270C}\x{200D}\x{D83C}\x{DFFC}\x{D83D}\x{DC6F}\x{200D}\x{D83C}\x{DFFB}\x{D83D}\x{DC6F}\x{200D}\x{D83C}\x{DFFF}\x{D83D}\x{DC72}\x{200D}\x{D83C}\x{DFFD}\x{D83D}\x{DC72}\x{200D}\x{D83C}\x{DFFB}"
Because content_shell is using a rather old version of FreeType that does not
support color font and Linux trybot does not have any emoji  font (color or b&w)
installed,  the test result on Linux has just a bunch of empty boxes for this
line (and other lines as well). [1]

Somehow, the font size in this line seems to be slightly different (or somehow
different rasterization is used). It's rather strange.



[1] I'll file a separate bug on this issue. Well, there's already a bug to
update libfreetype as used in content_shell, but this emoji test can be improved
as well by using a subsetted version of NotoColorEmoji.

https://codereview.chromium.org/2447513002/diff/210001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/platform/win/fast/text/color-emoji-expected.txt
(right):

https://codereview.chromium.org/2447513002/diff/210001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/platform/win/fast/text/color-emoji-expected.txt:40:
text run at (0,5) width 310: "zero-width-joiners:
\x{270C}\x{200D}\x{D83C}\x{DFFF}\x{270C}\x{200D}\x{D83C}\x{DFFC}\x{D83D}\x{DC6F}\x{200D}\x{D83C}\x{DFFB}\x{D83D}\x{DC6F}\x{200D}\x{D83C}\x{DFFF}\x{D83D}\x{DC72}\x{200D}\x{D83C}\x{DFFD}\x{D83D}\x{DC72}\x{200D}\x{D83C}\x{DFFB}"
png files are identical on platform/win, but txt is different. 
The correct width seems to be ~310 for this line because this line is
about 2/3 the width of line starting with 'For the following, each emoji should
...' whose width is 434. 

Somehow, ICU update seems to fix the width measurement of emoji-zwj sequences.

https://codereview.chromium.org/2447513002/diff/210001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/platform/win7/fast/text/color-emoji-expected.txt
(right):

https://codereview.chromium.org/2447513002/diff/210001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/platform/win7/fast/text/color-emoji-expected.txt:39:
LayoutText {#text} at (0,1) size 406x26
Win 7 does not have any color font. So, this line has a bunch of tofus (empty
boxes). Somehow, the width is slightly different.

png files (current and new) look identical to my casual eyes, but they're
different (binary diff).

[jungshik at Google, 2016-11-01 19:59:47]

http://jungshik.github.io/cr/layouttests/ : Dominik, you can take a look at the
above page for image expected files (current vs new on Linux, Win and win 7).

[drott, 2016-11-01 20:00:17]

Thanks for your work on the ICU update, that's great.

Thanks for the explanations, the color emoji test baseline change LGTM. Minor
changes in .notdef boxes are fine indeed.

Happy to hear the length measurement looks better.

>  fast/text/midword-break-before-surrogate-pair: expectation was wrong about
the
>    line breaking behavior of regional indiactors.

Regarding this one, I understand your modification is correct, but it would be
better to still have a line that overflows given break-all; - so for the second
part, can we find/use an example character that does not fall into one of the
categories that break-all applies to?

[drott, 2016-11-01 21:18:05]

LGTM with a TODO for updating the test and pointing to
https://bugs.chromium.org/p/chromium/issues/detail?id=661320 that you filed,
thank you!

[jungshik at Google, 2016-11-01 21:19:04]

On 2016/11/01 20:00:17, drott wrote:
> Thanks for your work on the ICU update, that's great.

Thank you for taking a look and review. 

> 
> Thanks for the explanations, the color emoji test baseline change LGTM. Minor
> changes in .notdef boxes are fine indeed.
> 
> Happy to hear the length measurement looks better.
> 
> >  fast/text/midword-break-before-surrogate-pair: expectation was wrong about
> the
> >    line breaking behavior of regional indiactors.
> 
> Regarding this one, I understand your modification is correct, but it would be
> better to still have a line that overflows given break-all; - so for the
second
> part, can we find/use an example character that does not fall into one of the
> categories that break-all applies to?

https://bugs.chromium.org/p/chromium/issues/detail?id=661320 (with some
candidate characters) 
was filed to deal with it. For now, I've just added a TODO comment.

[jungshik at Google, 2016-11-01 21:19:16]

The CQ bit was checked by jshin@chromium.org

[jungshik at Google, 2016-11-01 21:19:16]

The patchset sent to the CQ was uploaded after l-g-t-m from glevin@chromium.org,
jsbell@chromium.org, pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2447513002/#ps230001
(title: "add a TODO comment about non-BMP overflow test string with word-break:
break-all")

[commit-bot: I haz the power, 2016-11-01 21:20:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 21:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 21:20:41]

CQ has no permission to schedule in bucket tryserver.blink

[jungshik at Google, 2016-11-01 22:57:10]

to perf sheriff:

The following size increase (due to a size increase in icud data file) is
expected: 

The size impact:
   Non-Android: 10,127,200 => 10,128,624 (delta = 1,424 / 0.014%)
   Android: 6,563,152 => 6,571,936 (delta = 8,784 / 0.13%)

[jungshik at Google, 2016-11-02 06:18:47]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2016-11-02 06:19:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 06:19:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 06:19:16]

CQ has no permission to schedule in bucket tryserver.blink

[jungshik at Google, 2016-11-02 10:00:00]

The CQ bit was checked by jshin@chromium.org

[jungshik at Google, 2016-11-02 10:00:01]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org,
glevin@chromium.org, jsbell@chromium.org, pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2447513002/#ps250001
(title: "fix a typo in html comment")

[commit-bot: I haz the power, 2016-11-02 10:00:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 10:00:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 10:00:35]

CQ has no permission to schedule in bucket tryserver.blink

[jungshik at Google, 2016-11-02 17:09:58]

Description was changed from

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels



BUG=637001
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TEST=Layout tests, all unittests, browser tests
==========

to

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels



BUG=637001
TEST=Layout tests, all unittests, browser tests
==========

[jungshik at Google, 2016-11-02 17:10:16]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:10:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 17:16:47]

Description was changed from

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels



BUG=637001
TEST=Layout tests, all unittests, browser tests
==========

to

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels



BUG=637001
TEST=Layout tests, all unittests, browser tests
==========

[commit-bot: I haz the power, 2016-11-02 17:16:49]

Committed patchset #14 (id:250001)

[commit-bot: I haz the power, 2016-11-02 17:21:42]

Description was changed from

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels



BUG=637001
TEST=Layout tests, all unittests, browser tests
==========

to

==========
Update ICU to 58.1

See https://codereview.chromium.org/2442923002 for actual changes.

Fix base_unittests:NumberFormattingTest.FormatPercent per new percent formats
for Arabic and Persian in CLDR 30/ICU 58.

Adjust IsIDNComponentSafe() to keep the current behavior (therefore, no
changes in tests) with ICU 58.1 changes in uspoof API.

Rebaselined a few layout tests (no substantial changes) and changed one test.

  fast/text/midword-break-before-surrogate-pair: expectation was wrong about the
    line breaking behavior of regional indiactors.

The following two wpt tests are directly changed in our tree with an upstream
pull request made for the change:
  https://github.com/w3c/web-platform-tests/pull/4090

  imported/wpt/encoding/textdecoder-fatal-single-byte
  imported/wpt/encoding/textdecoder-labels

BUG=637001
TEST=Layout tests, all unittests, browser tests

Committed: https://crrev.com/b2b928ac0d2e7caabffd9a10b94e71ef534b206a
Cr-Commit-Position: refs/heads/master@{#429312}
==========

[commit-bot: I haz the power, 2016-11-02 17:21:44]

Patchset 14 (id:??) landed as
https://crrev.com/b2b928ac0d2e7caabffd9a10b94e71ef534b206a
Cr-Commit-Position: refs/heads/master@{#429312}

[please use gerrit instead, 2016-11-02 21:06:28]

Please see http://crbug.com/661764