Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/LayoutTests/fast/text/midword-break-before-surrogate-pair.html

Issue 2447513002: Update ICU to 58.1 (Closed)
Patch Set: fix a typo in html comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/text/midword-break-before-surrogate-pair.html
diff --git a/third_party/WebKit/LayoutTests/fast/text/midword-break-before-surrogate-pair.html b/third_party/WebKit/LayoutTests/fast/text/midword-break-before-surrogate-pair.html
index eb19482191af686244f20fd439230ccbfad4fa11..edcd66e9ffe34c1a3d5758aa9369f38468e8e052 100644
--- a/third_party/WebKit/LayoutTests/fast/text/midword-break-before-surrogate-pair.html
+++ b/third_party/WebKit/LayoutTests/fast/text/midword-break-before-surrogate-pair.html
@@ -15,13 +15,19 @@
</style>
</head>
<p>The following box should break the sequence of symbols at the 5 character mark
-and not overflow the blue box. This is because U+1D49 is a number category
- unicode character, for which break-all applies.</p>
+and not overflow the blue box. This is because U+1D49E has a general category(gC) of Letter, for which break-all applies.</p>
<div class="breakbox">
&#x1d49e;&#x1d49e;&#x1d49e;&#x1d49e;&#x1d49e;&#x1d49e;&#x1d49e;&#x1d49e;&#x1d49e;&#x1d49e;
</div>
-<p>The following box should not break the sequence of symbols since U+1F1EF is not
- a letter or number category character.</p>
+<p>The following box should break between a pair of regional indicators
+( U+1F1EF and U+1F1F5 ) because
+they (as a pair) act like Ideographs (LB=ID) whether or not 'word-break' is break-all.
+</p>
<div class="breakbox">
&#x1f1ef;&#x1f1f5;&#x1f1ef;&#x1f1f5;&#x1f1ef;&#x1f1f5;&#x1f1ef;&#x1f1f5;&#x1f1ef;&#x1f1f5;&#x1f1ef;&#x1f1f5;&#x1f1ef;&#x1f1f5;&#x1f1ef;&#x1f1f5;
</div>
+<!--
+ TODO(jshin): Add a test string made of non-BMP characters that would
+ overflow even with 'word-break: break-all'. LB=IS or LB=NS would work.
+ https://bugs.chromium.org/p/chromium/issues/detail?id=661320
+-->

Powered by Google App Engine
This is Rietveld 408576698