Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2442923002: ICU update to 58 part 2 (Closed)

Created:
4 years, 2 months ago by jungshik at Google
Modified:
4 years, 1 month ago
Reviewers:
Mark Mentovai, jsbell
CC:
chromium-reviews, drott
Target Ref:
refs/heads/master
Project:
icu
Visibility:
Public.

Description

ICU update to 58 part 2 Follw-up to https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad5 (due to a rietveld issue, part 1 was manually pushed). Update ICU to 58.1 release from ICU 56.1 part2. Listed below a tiny subset of what's new in 58.1: 1. Unicode 9.0 from Unicode 8.0 - Updated character properties including Emoji data up to 4.0beta. - Updated grapheme/word/line breaking rules for Emoji sequences and others. 2. CLDR 30.0.2 from CLDR 28 - Numerous locale data updates/improvements 3. Spoofing API changes 4. Greek uppercasing support as a part of regular case-mapping API. 5. Line breaking rule file format optimization. This change enables me to add CJ loose line breaking rules back (previously, it's dropped to save space) so that Blink can use it for CJ. See http://site.icu-project.org/download/58 for more details on ICU 58.1 and http://site.icu-project.org/download/57 for more details on ICU 57.1 For CLDR 30, see http://cldr.unicode.org/index/downloads/cldr-30 . The size impact: Non-Android: 10,127,200 => 10,128,624 (delta = 1,424 / 0.014%) Android: 6,563,152 => 6,571,936 (delta = 8,784 / 0.13%) Below are the list of changes made on top of the upstream ICU 58.1 in reverse order. Most of these changes were made in 58staging branch to run trybots and cherry-picked back for this CL. See https://chromium.googlesource.com/chromium/deps/icu/+/log/chromium/58staging https://codereview.chromium.org/2447513002/ : cr+blink update cl with 58staging branch head. * Fix a build on Win without std::string (v8) * Add ms932 alias to Shift_JIS * Apply Google-specific locale data patches * Fix a bug in scriptset * Update windows-1255 mapping * Disable C4333 warning by MSVC (harmless) * Apply and update utf32.patch and README.chromium * Update and apply vscomp.patch stringpiece patch removed. VS2015 seems to be fine with a redefinition. * Update pre-built ICU data files Update *local.mk with a new copyright line * Apply more patches The following patches were applied and updated: data_symb, vscomp, wpo The unnecessary part was dropped from vscomp * Update BUILD.gn and icu.gyp* files * Update android/brkitr.patch * Update and apply more patches * Update and apply cjdict.patch Apply data.build.patch * Delete obsolete patches: cmemory,regex * Update README.chromium and apply brkitr patches - Update README.chromium - Remove obsolete patches - Update linebrk.patch and apply it: add back line_loose_cj * Update wordbrk.patch and apply it * Update and apply khmer-dictbe.patch * Update data trimming - android/patch_locale.sh - scripts/trim_data.sh ExemplarCh* removed charac*Label removed relative/relativeTime removed for daysOfWeek and quarter * Update the following patches android/brkitr.patch patches/linebrk.patch patches/data.build.patch * Update cjdict.patch and linebrk.patch BUG=637001 TEST=Layout tests, all unittests, browser tests, ui tests. R=jsbell@chromium.org, mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/e0d9b90cae887a97977b0992f7a746eb1c01b9ac

Patch Set 1 #

Patch Set 2 : update README.chromium and remove READ_THIS_FIRST #

Patch Set 3 : update timezone to 2016h and update pre-built data files #

Patch Set 4 : apply more patches and updates; almost ready to roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1712 lines, -16820 lines) Patch
M BUILD.gn View 1 2 3 21 chunks +20 lines, -20 lines 0 comments Download
M README.chromium View 1 2 3 7 chunks +23 lines, -76 lines 0 comments Download
D READ_THIS_FIRST View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M android/brkitr.patch View 1 2 3 5 chunks +22 lines, -21 lines 0 comments Download
M android/icudtl.dat View 1 2 3 Binary file 0 comments Download
M android/patch_locale.sh View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M common/icudtb.dat View 1 2 3 Binary file 0 comments Download
M common/icudtl.dat View 1 2 3 Binary file 0 comments Download
M icu.gyp View 1 2 3 10 chunks +15 lines, -17 lines 0 comments Download
M icu.gypi View 1 2 3 9 chunks +6 lines, -6 lines 0 comments Download
M patches/cjdict.patch View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
D patches/cmemory.patch View 1 2 3 1 chunk +0 lines, -188 lines 0 comments Download
M patches/data.build.patch View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M patches/data.build.win.patch View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M patches/data_symb.patch View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A patches/digilist.patch View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
D patches/emoji_props.patch View 1 2 3 1 chunk +0 lines, -7535 lines 0 comments Download
M patches/khmer-dictbe.patch View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M patches/linebrk.patch View 1 2 3 3 chunks +23 lines, -28 lines 0 comments Download
M patches/locale1.patch View 1 2 3 4 chunks +15 lines, -24 lines 0 comments Download
D patches/locale_extra.patch View 1 2 3 1 chunk +0 lines, -59 lines 0 comments Download
M patches/locale_google.patch View 1 2 3 246 chunks +1005 lines, -826 lines 0 comments Download
D patches/measure_format.patch View 1 2 3 1 chunk +0 lines, -5474 lines 0 comments Download
D patches/regex.patch View 1 2 3 1 chunk +0 lines, -1314 lines 0 comments Download
D patches/regexcmp.patch View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
D patches/relative_date.patch View 1 2 3 1 chunk +0 lines, -48 lines 0 comments Download
D patches/remove_si.patch View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
A patches/scriptset.patch View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
D patches/tzdetect.patch View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D patches/utext.patch View 1 2 3 1 chunk +0 lines, -176 lines 0 comments Download
M patches/utf32.patch View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M patches/vscomp.patch View 1 2 3 3 chunks +3 lines, -48 lines 0 comments Download
M patches/wordbrk.patch View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M patches/wpo.patch View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
D patches/xlit_badcast.patch View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/trim_data.sh View 1 2 3 6 chunks +23 lines, -8 lines 0 comments Download
M source/common/dictbe.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/common/locmap.c View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M source/common/ucmndata.h View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M source/common/ucnv_bld.cpp View 1 2 3 4 chunks +1 line, -7 lines 0 comments Download
M source/common/ucnv_u32.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M source/common/udata.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M source/common/unicode/utypes.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M source/data/Makefile.in View 1 2 3 4 chunks +15 lines, -4 lines 0 comments Download
M source/data/brkitr/brklocal.mk View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M source/data/brkitr/dictionaries/cjdict.txt View 1 2 3 4 chunks +7 lines, -0 lines 0 comments Download
M source/data/brkitr/fi.txt View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M source/data/brkitr/root.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/brkitr/rules/word.txt View 1 2 3 1 chunk +9 lines, -3 lines 0 comments Download
M source/data/brkitr/zh.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M source/data/brkitr/zh_Hant.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M source/data/coll/collocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/curr/reslocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/curr/ru.txt View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M source/data/curr/uk.txt View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M source/data/lang/reslocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/locales/hi.txt View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M source/data/locales/ko.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M source/data/locales/reslocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/locales/ta.txt View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/makedata.mak View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M source/data/mappings/convrtrs.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M source/data/mappings/windows-1255-html.ucm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M source/data/misc/likelySubtags.txt View 1 2 3 5 chunks +4 lines, -3 lines 0 comments Download
M source/data/misc/metadata.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M source/data/misc/supplementalData.txt View 1 2 3 5 chunks +10 lines, -9 lines 0 comments Download
M source/data/misc/zoneinfo64.txt View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M source/data/rbnf/rbnflocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/region/af.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/am.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ar.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ast.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/az.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/az_Cyrl.txt View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M source/data/region/be.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/bg.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/bn.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/br.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/bs.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/bs_Cyrl.txt View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M source/data/region/ca.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ce.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/chr.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ckb.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M source/data/region/cs.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/cy.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/da.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/de.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/dsb.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/dz.txt View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M source/data/region/ee.txt View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M source/data/region/el.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/en.txt View 1 2 3 6 chunks +7 lines, -10 lines 0 comments Download
M source/data/region/es.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/et.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/eu.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/fa.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/fi.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/fil.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/fo.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/fr.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/fur.txt View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M source/data/region/fy.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ga.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/gd.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/gl.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/gsw.txt View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M source/data/region/gu.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/he.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/hi.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/hr.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/hsb.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/hu.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/hy.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/id.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/is.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/it.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ja.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ka.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/kea.txt View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M source/data/region/kk.txt View 1 2 3 5 chunks +4 lines, -7 lines 0 comments Download
M source/data/region/km.txt View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M source/data/region/kn.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ko.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ksh.txt View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M source/data/region/ky.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/lb.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/lo.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/lt.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/lv.txt View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M source/data/region/mk.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ml.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/mn.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/mr.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ms.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/mt.txt View 1 2 3 4 chunks +3 lines, -12 lines 0 comments Download
M source/data/region/my.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/mzn.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/nb.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ne.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/nl.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/nn.txt View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M source/data/region/pa.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/pl.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/pt.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/reslocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/region/ro.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ru.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/se.txt View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M source/data/region/si.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/sk.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/sl.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/smn.txt View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M source/data/region/sq.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/sr.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/sr_Latn.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/sv.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/sw.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ta.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/te.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/th.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/to.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/tr.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/ug.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/uk.txt View 1 2 3 5 chunks +4 lines, -7 lines 0 comments Download
M source/data/region/ur.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/uz.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/uz_Cyrl.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/vi.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/wae.txt View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M source/data/region/yue.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/zh.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/zh_Hant.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/region/zu.txt View 1 2 3 4 chunks +3 lines, -6 lines 0 comments Download
M source/data/sprep/spreplocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/unit/reslocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/zone/ko.txt View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M source/data/zone/reslocal.mk View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/zone/zh.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M source/data/zone/zh_Hant.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M source/i18n/digitlst.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M source/i18n/scriptset.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M source/stubdata/stubdata.c View 1 2 3 1 chunk +20 lines, -31 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
jungshik at Google
Mark and Joshua, can you take a look? There are only few places to take ...
4 years, 1 month ago (2016-10-27 19:06:50 UTC) #9
Mark Mentovai
LGTM
4 years, 1 month ago (2016-10-27 21:07:15 UTC) #10
jsbell
lgtm! As always, thanks for the thorough notes and rigorous details in the README file ...
4 years, 1 month ago (2016-10-27 21:43:30 UTC) #11
jsbell
On 2016/10/27 19:06:50, jungshik at google wrote: > source/data/mappings/* : for Joshua. Picked up a ...
4 years, 1 month ago (2016-10-27 21:48:11 UTC) #12
jungshik at Google
Thank you, Joshua and Mark, for the approval. On 2016/10/27 21:48:11, jsbell wrote: > On ...
4 years, 1 month ago (2016-10-28 19:55:25 UTC) #13
jungshik at Google
4 years, 1 month ago (2016-10-28 19:57:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:30001) manually as
e0d9b90cae887a97977b0992f7a746eb1c01b9ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698