Always use Desktop GL 4.1 or less BindBufferRange behavior.

Always use Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7f4fd7233c76ecf76a25594040722798dcbb69a8
Cr-Commit-Position: refs/heads/master@{#427224}

[Zhenyao Mo, 2016-10-24 21:30:22]

Description was changed from

==========
Always Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
==========

to

==========
Always Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-24 21:31:34]

kbr: could you review this?
Others: FYI (feel free to review)

[Zhenyao Mo, 2016-10-24 21:31:40]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-10-24 21:32:59]

Description was changed from

==========
Always Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Always use Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-24 21:33:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-10-24 21:39:24]

Very good. LGTM

https://codereview.chromium.org/2446773002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2446773002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3108: // do not handle
out-of-bounds visit securely.
How about "visit" -> "accesses"?

[Zhenyao Mo, 2016-10-24 21:47:30]

https://codereview.chromium.org/2446773002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2446773002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3108: // do not handle
out-of-bounds visit securely.
On 2016/10/24 21:39:24, Ken Russell wrote:
> How about "visit" -> "accesses"?

Done.

[Zhenyao Mo, 2016-10-24 21:48:03]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-10-24 21:48:04]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2446773002/#ps20001
(title: "fix comments")

[commit-bot: I haz the power, 2016-10-24 21:48:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 23:44:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:44:03]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Zhenyao Mo, 2016-10-24 23:55:01]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:39:46]

Description was changed from

==========
Always use Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Always use Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-25 01:39:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 01:41:42]

Description was changed from

==========
Always use Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Always use Desktop GL 4.1 or less BindBufferRange behavior.

On Desktop 4.2 or later, and on ES3, BindBufferRange can be called
without enough data store to backup the offset and size, assuming
drivers will handle the out-of-bounds access correctly.

In Chrome we play it safe by not trusting the drivers and emulate the
older behavior everywhere (not just where it is required).

BUG=429053
TEST=gpu_unittests
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7f4fd7233c76ecf76a25594040722798dcbb69a8
Cr-Commit-Position: refs/heads/master@{#427224}
==========

[commit-bot: I haz the power, 2016-10-25 01:41:43]

Patchset 2 (id:??) landed as
https://crrev.com/7f4fd7233c76ecf76a25594040722798dcbb69a8
Cr-Commit-Position: refs/heads/master@{#427224}