Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2446313003: Revise InterfaceRegistry API to support filtering interfaces @ Bind() time. (Closed)

Created:
4 years, 1 month ago by Ben Goodger (Google)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revise InterfaceRegistry API to support filtering interfaces @ Bind() time. InterfaceRegistry is now constructed with local service info: the local service identity and the spec exposed via the IR. Later, Bind() is called with the IPRequest & the remote service identity & spec. This moves interface intersection logic of specs to the client library from the service manager, & removes the allowed_interfaces and allowed_capabilities parameters from service.mojom:Service::OnConnect() which are now redundant. Hooks this up for connection-level specs in service manager & client library (service_context.cc R=rockot@chromium.org,tsepez@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/c87e52bc73fe59a5d460cd2e60ff7838f79d8ebf Cr-Commit-Position: refs/heads/master@{#427771}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -170 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 chunks +10 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 2 3 3 chunks +8 lines, -3 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 2 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_instance_client_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/webui/mojo_facade_unittest.mm View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M services/catalog/manifest.json View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M services/service_manager/manifest.json View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M services/service_manager/public/cpp/identity.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/public/cpp/interface_registry.h View 1 2 3 2 chunks +19 lines, -13 lines 0 comments Download
M services/service_manager/public/cpp/lib/identity.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/lib/interface_registry.cc View 1 2 3 4 5 6 7 4 chunks +74 lines, -13 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 1 2 3 4 5 6 7 8 9 2 chunks +16 lines, -8 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M services/service_manager/public/cpp/tests/interface_registry_unittest.cc View 1 2 3 4 5 5 chunks +11 lines, -11 lines 0 comments Download
M services/service_manager/public/interfaces/service.mojom View 1 2 1 chunk +1 line, -15 lines 0 comments Download
M services/service_manager/service_manager.cc View 1 2 3 chunks +2 lines, -61 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_class_app_manifest.json View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M services/ui/manifest.json View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 57 (41 generated)
Ben Goodger (Google)
ken: * tom: service.mojom
4 years, 1 month ago (2016-10-25 23:38:40 UTC) #20
Tom Sepez
Mojom LGTM per conversation.
4 years, 1 month ago (2016-10-25 23:48:37 UTC) #23
Ken Rockot(use gerrit already)
LGTM - some red (iOS code creates an InterfaceRegistry, and looks like blimp is busted)
4 years, 1 month ago (2016-10-25 23:52:44 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446313003/100001
4 years, 1 month ago (2016-10-26 00:05:47 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/94352)
4 years, 1 month ago (2016-10-26 00:21:54 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446313003/120001
4 years, 1 month ago (2016-10-26 02:36:34 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/94474)
4 years, 1 month ago (2016-10-26 02:52:11 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446313003/140001
4 years, 1 month ago (2016-10-26 05:41:12 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/302940)
4 years, 1 month ago (2016-10-26 06:18:17 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446313003/160001
4 years, 1 month ago (2016-10-26 06:37:54 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/324694)
4 years, 1 month ago (2016-10-26 08:53:50 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446313003/180001
4 years, 1 month ago (2016-10-26 17:20:41 UTC) #49
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/94246)
4 years, 1 month ago (2016-10-26 17:29:07 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446313003/180001
4 years, 1 month ago (2016-10-26 17:39:54 UTC) #53
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 1 month ago (2016-10-26 19:07:16 UTC) #55
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 19:22:26 UTC) #57
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/c87e52bc73fe59a5d460cd2e60ff7838f79d8ebf
Cr-Commit-Position: refs/heads/master@{#427771}

Powered by Google App Engine
This is Rietveld 408576698