Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2446313003: Revise InterfaceRegistry API to support filtering interfaces @ Bind() time. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index f1770ffec0e8af3d51c9621d723bd1ba0e3b081d..2fd975e66ceff2b3345e3d2b75077b01168a85df 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -811,8 +811,8 @@ void RenderFrameHostImpl::RenderProcessGone(SiteInstanceImpl* site_instance) {
void RenderFrameHostImpl::Create(
const service_manager::Identity& remote_identity,
media::mojom::InterfaceFactoryRequest request) {
- std::unique_ptr<service_manager::InterfaceRegistry> registry(
- new service_manager::InterfaceRegistry);
+ auto registry = base::MakeUnique<service_manager::InterfaceRegistry>(
+ service_manager::Identity(), service_manager::InterfaceProviderSpec());
#if defined(OS_ANDROID) && defined(ENABLE_MOJO_CDM)
registry->AddInterface(
base::Bind(&ProvisionFetcherImpl::Create, this));
@@ -820,7 +820,9 @@ void RenderFrameHostImpl::Create(
GetContentClient()->browser()->ExposeInterfacesToMediaService(registry.get(),
this);
service_manager::mojom::InterfaceProviderPtr interfaces;
- registry->Bind(GetProxy(&interfaces));
+ registry->Bind(GetProxy(&interfaces),
+ service_manager::Identity(),
+ service_manager::InterfaceProviderSpec());
media_registries_.push_back(std::move(registry));
// TODO(slan): Use the BrowserContext Connector instead. See crbug.com/638950.
@@ -2580,7 +2582,8 @@ void RenderFrameHostImpl::SetUpMojoIfNeeded() {
if (interface_registry_.get())
return;
- interface_registry_.reset(new service_manager::InterfaceRegistry);
+ interface_registry_ = base::MakeUnique<service_manager::InterfaceRegistry>(
+ service_manager::Identity(), service_manager::InterfaceProviderSpec());
if (!GetProcess()->GetRemoteInterfaces())
return;
@@ -2864,7 +2867,9 @@ void RenderFrameHostImpl::FilesSelectedInChooser(
void RenderFrameHostImpl::GetInterfaceProvider(
service_manager::mojom::InterfaceProviderRequest interfaces) {
- interface_registry_->Bind(std::move(interfaces));
+ interface_registry_->Bind(std::move(interfaces),
+ service_manager::Identity(),
+ service_manager::InterfaceProviderSpec());
}
#if defined(USE_EXTERNAL_POPUP_MENU)
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698