Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: services/service_manager/public/cpp/tests/interface_registry_unittest.cc

Issue 2446313003: Revise InterfaceRegistry API to support filtering interfaces @ Bind() time. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/service_manager/public/cpp/interface_registry.h" 5 #include "services/service_manager/public/cpp/interface_registry.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "services/service_manager/public/cpp/interface_binder.h" 8 #include "services/service_manager/public/cpp/interface_binder.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace service_manager { 11 namespace service_manager {
12 namespace internal {
13 namespace {
14 12
15 class TestBinder : public InterfaceBinder { 13 class TestBinder : public InterfaceBinder {
16 public: 14 public:
17 explicit TestBinder(int* delete_count) : delete_count_(delete_count) {} 15 explicit TestBinder(int* delete_count) : delete_count_(delete_count) {}
18 ~TestBinder() override { (*delete_count_)++; } 16 ~TestBinder() override { (*delete_count_)++; }
19 void BindInterface(const service_manager::Identity& remote_identity, 17 void BindInterface(const service_manager::Identity& remote_identity,
20 const std::string& interface_name, 18 const std::string& interface_name,
21 mojo::ScopedMessagePipeHandle client_handle) override {} 19 mojo::ScopedMessagePipeHandle client_handle) override {}
22 20
23 private: 21 private:
24 int* delete_count_; 22 int* delete_count_;
25 }; 23 };
26 24
27 TEST(InterfaceRegistryTest, Ownership) { 25 TEST(InterfaceRegistryTest, Ownership) {
28 base::MessageLoop message_loop_; 26 base::MessageLoop message_loop_;
29 int delete_count = 0; 27 int delete_count = 0;
30 28
31 // Destruction. 29 // Destruction.
32 { 30 {
33 InterfaceRegistry registry; 31 auto registry = base::MakeUnique<service_manager::InterfaceRegistry>(
34 InterfaceRegistry::TestApi test_api(&registry); 32 Identity(), InterfaceProviderSpec());
33 InterfaceRegistry::TestApi test_api(registry.get());
35 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1"); 34 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1");
36 } 35 }
37 EXPECT_EQ(1, delete_count); 36 EXPECT_EQ(1, delete_count);
38 37
39 // Removal. 38 // Removal.
40 { 39 {
41 std::unique_ptr<InterfaceRegistry> registry(new InterfaceRegistry); 40 auto registry = base::MakeUnique<InterfaceRegistry>(
41 Identity(), InterfaceProviderSpec());
42 InterfaceBinder* b = new TestBinder(&delete_count); 42 InterfaceBinder* b = new TestBinder(&delete_count);
43 InterfaceRegistry::TestApi test_api(registry.get()); 43 InterfaceRegistry::TestApi test_api(registry.get());
44 test_api.SetInterfaceBinderForName(b, "TC1"); 44 test_api.SetInterfaceBinderForName(b, "TC1");
45 registry->RemoveInterface("TC1"); 45 registry->RemoveInterface("TC1");
46 registry.reset(); 46 registry.reset();
47 EXPECT_EQ(2, delete_count); 47 EXPECT_EQ(2, delete_count);
48 } 48 }
49 49
50 // Multiple. 50 // Multiple.
51 { 51 {
52 InterfaceRegistry registry; 52 auto registry = base::MakeUnique<service_manager::InterfaceRegistry>(
53 InterfaceRegistry::TestApi test_api(&registry); 53 Identity(), InterfaceProviderSpec());
54 InterfaceRegistry::TestApi test_api(registry.get());
54 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1"); 55 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1");
55 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC2"); 56 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC2");
56 } 57 }
57 EXPECT_EQ(4, delete_count); 58 EXPECT_EQ(4, delete_count);
58 59
59 // Re-addition. 60 // Re-addition.
60 { 61 {
61 InterfaceRegistry registry; 62 auto registry = base::MakeUnique<service_manager::InterfaceRegistry>(
62 InterfaceRegistry::TestApi test_api(&registry); 63 Identity(), InterfaceProviderSpec());
64 InterfaceRegistry::TestApi test_api(registry.get());
63 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1"); 65 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1");
64 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1"); 66 test_api.SetInterfaceBinderForName(new TestBinder(&delete_count), "TC1");
65 EXPECT_EQ(5, delete_count); 67 EXPECT_EQ(5, delete_count);
66 } 68 }
67 EXPECT_EQ(6, delete_count); 69 EXPECT_EQ(6, delete_count);
68 } 70 }
69 71
70 } // namespace
71 } // namespace internal
72 } // namespace service_manager 72 } // namespace service_manager
OLDNEW
« no previous file with comments | « services/service_manager/public/cpp/service_context.h ('k') | services/service_manager/public/interfaces/service.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698