Add frame-specific InterfaceProviderSpec.

Add frame-specific InterfaceProviderSpec.

Interfaces exposed between browser <--> renderer at the frame level are now controlled via the "navigation:frame" InterfaceProviderSpec.

Wires ServiceInfo from IO thread thru to main thread @ connect time.

Changes InterfaceRegistry ctor back to take no params, and passes local info @ Bind() time. Reason is, content code creates IR before OnStart is called, no way to know local info. Turns out only needed at Bind() time.

Will convert other InterfaceRegistry uses in separate CLs.

R=rockot@chromium.org,tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/275a565819b71dc186f9b4a5249fda24058d364b
Cr-Commit-Position: refs/heads/master@{#428394}

[Ben Goodger (Google), 2016-10-26 21:19:21]

Description was changed from

==========
Add frame-specific InterfaceProviderSpec.

R=rockot@chromium.org,tsepez@chromium.org
==========

to

==========
Add frame-specific InterfaceProviderSpec.

R=rockot@chromium.org,tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-10-26 21:57:20]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:58:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:10:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:10:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Ben Goodger (Google), 2016-10-26 23:37:41]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 23:38:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 23:48:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 23:48:28]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Ben Goodger (Google), 2016-10-27 00:22:26]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 00:23:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-10-27 00:25:27]

Description was changed from

==========
Add frame-specific InterfaceProviderSpec.

R=rockot@chromium.org,tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add frame-specific InterfaceProviderSpec.

Interfaces exposed between browser <--> renderer at the frame level are now
controlled via the "navigation:frame" InterfaceProviderSpec.

Wires ServiceInfo from IO thread thru to main thread @ connect time.

Changes InterfaceRegistry ctor back to take no params, and passes local info @
Bind() time. Reason is, content code creates IR before OnStart is called, no way
to know local info. Turns out only needed at Bind() time.

Will convert other InterfaceRegistry uses in separate CLs.

R=rockot@chromium.org,tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-10-27 00:25:46]

ken: *
tom: *.json

[commit-bot: I haz the power, 2016-10-27 00:48:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:48:10]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ben Goodger (Google), 2016-10-27 04:51:29]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 04:51:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-10-27 04:51:52]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 04:51:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-10-27 04:52:36]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 04:52:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-10-27 05:12:52]

LGTM just some nits. At a quick glance, the red appears to be all due to some
missing interfaces in specs

https://codereview.chromium.org/2456493003/diff/60001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.h (right):

https://codereview.chromium.org/2456493003/diff/60001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.h:964:
service_manager::ServiceInfo local_info_;
nit: maybe browser_info_ and renderer_info_ would be better names

https://codereview.chromium.org/2456493003/diff/60001/content/child/child_thr...
File content/child/child_thread_impl.h (right):

https://codereview.chromium.org/2456493003/diff/60001/content/child/child_thr...
content/child/child_thread_impl.h:111: const service_manager::ServiceInfo&
GetChildServiceInfo() const;
nit: Could you also expose a bool IsConnectedToBrowser() or something, and
document specifically that these are available when that's true? Then RFI could
DCHECK it to clarify before accessing these, maybe with some clarification that
the code is unreachable until the browser is connected.

https://codereview.chromium.org/2456493003/diff/60001/content/child/child_thr...
content/child/child_thread_impl.h:276: void OnConnect(const
service_manager::ServiceInfo& local_info,
Maybe a more descriptive name like OnServiceConnection since it's less clear
what "OnConnect" means in the context of a ChildThreadImpl

https://codereview.chromium.org/2456493003/diff/60001/content/common/service_...
File content/common/service_manager/service_manager_connection_impl.cc (right):

https://codereview.chromium.org/2456493003/diff/60001/content/common/service_...
content/common/service_manager/service_manager_connection_impl.cc:533:
last_remote_info_ = remote_info;
last_remote_info_ is not used. remove?

[commit-bot: I haz the power, 2016-10-27 05:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 05:41:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ben Goodger (Google), 2016-10-27 06:45:27]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 06:45:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 07:28:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 07:28:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ben Goodger (Google), 2016-10-27 14:17:34]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 14:17:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 14:53:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 14:53:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-10-27 14:59:28]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 14:59:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:27:00]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ben Goodger (Google), 2016-10-27 15:35:01]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 15:35:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 16:17:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 16:17:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tom Sepez, 2016-10-27 16:26:25]

lgtm

[Ben Goodger (Google), 2016-10-27 18:18:55]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 18:19:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 19:03:04]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ben Goodger (Google), 2016-10-27 20:23:32]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:24:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 21:16:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 21:16:50]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ben Goodger (Google), 2016-10-27 23:27:48]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-10-27 23:27:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2456493003/#ps240001
(title: ".")

[commit-bot: I haz the power, 2016-10-27 23:28:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:54:52]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ben Goodger (Google), 2016-10-27 23:59:09]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-10-27 23:59:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2456493003/#ps260001
(title: ".")

[commit-bot: I haz the power, 2016-10-27 23:59:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 00:49:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 00:49:22]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ben Goodger (Google), 2016-10-28 02:26:16]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-10-28 02:26:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2456493003/#ps280001
(title: ".")

[commit-bot: I haz the power, 2016-10-28 02:26:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 03:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 03:41:33]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-10-28 14:05:20]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-10-28 14:05:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2456493003/#ps300001
(title: ".")

[commit-bot: I haz the power, 2016-10-28 14:05:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 15:06:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 15:06:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-10-28 15:09:14]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-10-28 15:09:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2456493003/#ps320001
(title: ".")

[commit-bot: I haz the power, 2016-10-28 15:09:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 16:56:17]

Description was changed from

==========
Add frame-specific InterfaceProviderSpec.

Interfaces exposed between browser <--> renderer at the frame level are now
controlled via the "navigation:frame" InterfaceProviderSpec.

Wires ServiceInfo from IO thread thru to main thread @ connect time.

Changes InterfaceRegistry ctor back to take no params, and passes local info @
Bind() time. Reason is, content code creates IR before OnStart is called, no way
to know local info. Turns out only needed at Bind() time.

Will convert other InterfaceRegistry uses in separate CLs.

R=rockot@chromium.org,tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add frame-specific InterfaceProviderSpec.

Interfaces exposed between browser <--> renderer at the frame level are now
controlled via the "navigation:frame" InterfaceProviderSpec.

Wires ServiceInfo from IO thread thru to main thread @ connect time.

Changes InterfaceRegistry ctor back to take no params, and passes local info @
Bind() time. Reason is, content code creates IR before OnStart is called, no way
to know local info. Turns out only needed at Bind() time.

Will convert other InterfaceRegistry uses in separate CLs.

R=rockot@chromium.org,tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-28 16:56:19]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2016-10-28 17:21:47]

Description was changed from

==========
Add frame-specific InterfaceProviderSpec.

Interfaces exposed between browser <--> renderer at the frame level are now
controlled via the "navigation:frame" InterfaceProviderSpec.

Wires ServiceInfo from IO thread thru to main thread @ connect time.

Changes InterfaceRegistry ctor back to take no params, and passes local info @
Bind() time. Reason is, content code creates IR before OnStart is called, no way
to know local info. Turns out only needed at Bind() time.

Will convert other InterfaceRegistry uses in separate CLs.

R=rockot@chromium.org,tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add frame-specific InterfaceProviderSpec.

Interfaces exposed between browser <--> renderer at the frame level are now
controlled via the "navigation:frame" InterfaceProviderSpec.

Wires ServiceInfo from IO thread thru to main thread @ connect time.

Changes InterfaceRegistry ctor back to take no params, and passes local info @
Bind() time. Reason is, content code creates IR before OnStart is called, no way
to know local info. Turns out only needed at Bind() time.

Will convert other InterfaceRegistry uses in separate CLs.

R=rockot@chromium.org,tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/275a565819b71dc186f9b4a5249fda24058d364b
Cr-Commit-Position: refs/heads/master@{#428394}
==========

[commit-bot: I haz the power, 2016-10-28 17:21:50]

Patchset 17 (id:??) landed as
https://crrev.com/275a565819b71dc186f9b4a5249fda24058d364b
Cr-Commit-Position: refs/heads/master@{#428394}

[Will Harris, 2016-10-31 21:27:18]

This CL is causing major regressions for navigation to chrome:// URLs. I think
this CL should be reverted ASAP until additional testing can be added to ensure
all the interfaces are added.

bugs is 660772.

[Sami, 2016-11-01 11:25:21]

Looks like this made the headless bot[1] a bit unhappy -- couple of tests are
failing with this crash stack. Any idea what might be wrong?

[ RUN      ] MojoBindingsReinstalledAfterNavigation.RunAsyncTest
[13404:13404:1028/101429:492409902:INFO:fake_audio_manager.cc(23)]
FakeAudioManager
[13404:13404:1028/101434:497883741:ERROR:interface_registry.cc(160)]
InterfaceProviderSpec "navigation:frame" prevented service:
service:content_renderer from binding interface:
embedder_test::TestEmbedderService exposed by: service:content_browser
[13404:13404:1028/101434:497883817:ERROR:render_process_host_impl.cc(2981)]
Terminating render process for bad Mojo message: Received bad user message:
InterfaceProviderSpec "navigation:frame" prevented service:
service:content_renderer from binding interface:
embedder_test::TestEmbedderService exposed by: service:content_browser
[13404:13404:1028/101434:497883856:ERROR:bad_message.cc(23)] Terminating
renderer for bad IPC message, reason 123
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x7f3a50809c1e base::debug::StackTrace::StackTrace()
#1 0x0000008d99b7 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f3a40612cb0 <unknown>
#3 0x7f3a406d6a13 epoll_wait
#4 0x7f3a50afef71 epoll_dispatch
#5 0x7f3a50af2385 event_base_loop
#6 0x7f3a508bbc82 base::MessagePumpLibevent::Run()
#7 0x7f3a508a1b8a base::MessageLoop::RunHandler()
#8 0x7f3a50946544 base::RunLoop::Run()
#9 0x0000004be46a headless::HeadlessBrowserTest::RunAsynchronousTest()
#10 0x0000004682f2 headless::EmbedderMojoTest::RunTest()
#11 0x000000467c05
headless::MojoBindingsReinstalledAfterNavigation_RunAsyncTest_Test::RunTestOnMainThread()
#12 0x0000004be10e headless::HeadlessBrowserTest::RunTestOnMainThreadLoop()
#13 0x0000008d96d3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#14 0x00000049c095
_ZN4base8internal13FunctorTraitsIMN8headless35HeadlessBrowserContextIsolationTestEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#15 0x00000049bfb1
_ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN8headless35HeadlessBrowserContextIsolationTestEFvvEJPS5_EEEvOT_DpOT0_
#16 0x0000008db227
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#17 0x0000008db16c
_ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#18 0x7f3a5080fb01
_ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv
#19 0x7f3a5080f509 base::debug::TaskAnnotator::RunTask()
#20 0x7f3a508a200a base::MessageLoop::RunTask()

[1]
https://build.chromium.org/p/chromium.fyi/builders/Headless%20Linux%20%28dbg%...

[Ben Goodger (Google), 2016-11-01 13:58:58]

Sami - you need to add an overlay for the content browser manifest, and permit
"embedder_test::TestEmbedderService" to be added to the navigation:frame
interface from it.

For a trivial example, see how android_webview does it:

https://chromium.googlesource.com/chromium/src/+/master/android_webview/brows...
https://chromium.googlesource.com/chromium/src/+/master/android_webview/brows...

[Sami, 2016-11-02 12:00:37]

On 2016/11/01 13:58:58, Ben Goodger (Google) wrote:
> Sami - you need to add an overlay for the content browser manifest, and permit
> "embedder_test::TestEmbedderService" to be added to the navigation:frame
> interface from it.
> 
> For a trivial example, see how android_webview does it:
> 
>
https://chromium.googlesource.com/chromium/src/+/master/android_webview/brows...
>
https://chromium.googlesource.com/chromium/src/+/master/android_webview/brows...

Thank you, that did the trick!