Reduce buggy usage of the registry controlled domain service.

Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

Reland of https://codereview.chromium.org/2433583002/ with fix.

R=pkasting
BUG=657199
Committed: https://crrev.com/0a8baeebb5bb84e4dc2449c6860f32928eaa6d4c
Cr-Commit-Position: refs/heads/master@{#427779}

[brettw, 2016-10-26 16:47:37]

Description was changed from

==========
Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

BUG=657199
==========

to

==========
Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

Reland of https://codereview.chromium.org/2433583002/ with fix.

TBR=pkasting
BUG=657199
==========

[brettw, 2016-10-26 16:47:37]

brettw@chromium.org changed reviewers:
+ pkasting@chromium.org

[brettw, 2016-10-26 17:08:15]

cronet fix

[brettw, 2016-10-26 17:08:16]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 17:08:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-10-26 17:09:47]

TBR reland, diff is in PS1 (skip IDN tests when we're not linking ICU)

[brettw, 2016-10-26 17:09:56]

The CQ bit was unchecked by brettw@chromium.org

[Peter Kasting, 2016-10-26 17:11:48]

LGTM

https://codereview.chromium.org/2446273004/diff/20001/net/base/registry_contr...
File net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc
(right):

https://codereview.chromium.org/2446273004/diff/20001/net/base/registry_contr...
net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc:572:
#if !BUILDFLAG(USE_PLATFORM_ICU_ALTERNATIVES)
Nit: Might want to note in a comment why this section requires that this build
flag be disabled.

[brettw, 2016-10-26 17:34:08]

Description was changed from

==========
Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

Reland of https://codereview.chromium.org/2433583002/ with fix.

TBR=pkasting
BUG=657199
==========

to

==========
Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

Reland of https://codereview.chromium.org/2433583002/ with fix.

R=pkasting
BUG=657199
==========

[brettw, 2016-10-26 17:42:53]

Review comment

[brettw, 2016-10-26 17:42:54]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-26 17:42:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2446273004/#ps40001
(title: "Review comment")

[commit-bot: I haz the power, 2016-10-26 17:43:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:47:53]

Description was changed from

==========
Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

Reland of https://codereview.chromium.org/2433583002/ with fix.

R=pkasting
BUG=657199
==========

to

==========
Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

Reland of https://codereview.chromium.org/2433583002/ with fix.

R=pkasting
BUG=657199
==========

[commit-bot: I haz the power, 2016-10-26 19:47:56]

Committed patchset #3 (id:40001)

[brettw, 2016-10-26 19:55:48]

https://codereview.chromium.org/2446273004/diff/20001/net/base/registry_contr...
File net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc
(right):

https://codereview.chromium.org/2446273004/diff/20001/net/base/registry_contr...
net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc:572:
#if !BUILDFLAG(USE_PLATFORM_ICU_ALTERNATIVES)
On 2016/10/26 17:11:48, Peter Kasting wrote:
> Nit: Might want to note in a comment why this section requires that this build
> flag be disabled.

Done.

[commit-bot: I haz the power, 2016-10-26 20:00:19]

Description was changed from

==========
Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

Reland of https://codereview.chromium.org/2433583002/ with fix.

R=pkasting
BUG=657199
==========

to

==========
Reduce buggy usage of the registry controlled domain service.

GetRegistryLength for host names canonicalizes the input for the caller, but
then returns the length in the canonicalized input, which is not necessarily
the same as the length in the original string. As a result, computations
performed by the caller based on this value can be wrong (see the bug for
more).

All callers of this function were audited and changed to use on of the
following:

- Many callers don't need the offsets. A new function
  HostHasRegistryControlledDomain is added to check for the presence of
  a R.C.D. without the risk of returning incorrect string lengths.

- Many callers already have guaranteed-canonical strings (they came out of
  a GURL or KURL object soon before the call) These were changed to use a
  new GetCanonicalHostRegistryLength function. A further advantage is that
  these calls will be faster.

- A new Permissive function is added that handles cases where the input
  is necessarily non-canonical.

Adds an IDN test case to the unit tests.

Removes checking for IP addresses in the already-known-canonical cases.
This requires a separate full canonicalization and IP addresses should
never match the R.C.D. list.

Reland of https://codereview.chromium.org/2433583002/ with fix.

R=pkasting
BUG=657199

Committed: https://crrev.com/0a8baeebb5bb84e4dc2449c6860f32928eaa6d4c
Cr-Commit-Position: refs/heads/master@{#427779}
==========

[commit-bot: I haz the power, 2016-10-26 20:00:20]

Patchset 3 (id:??) landed as
https://crrev.com/0a8baeebb5bb84e4dc2449c6860f32928eaa6d4c
Cr-Commit-Position: refs/heads/master@{#427779}

[wychen, 2016-10-26 20:07:21]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2454813002/ by wychen@chromium.org.

The reason for reverting is: compile failure on Cronet Builders.

[wychen, 2016-10-26 21:54:07]

wychen@chromium.org changed reviewers:
+ wychen@chromium.org

[wychen, 2016-10-26 21:54:07]

Failed builds:

https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Bui...
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM...
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Lol...
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Mar...