components/omnibox/browser/autocomplete_input.cc - Issue 2446273004: Reduce buggy usage of the registry controlled domain service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_input.cc

Issue 2446273004: Reduce buggy usage of the registry controlled domain service. (Closed)

Patch Set: Review comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/autocomplete_input.cc

diff --git a/components/omnibox/browser/autocomplete_input.cc b/components/omnibox/browser/autocomplete_input.cc

index 26a8c7d0f34a1bb70d358f02d0ee768a68f2cf83..a39d823b81e7648e00519e97eefbb15f40e46449 100644

--- a/components/omnibox/browser/autocomplete_input.cc

+++ b/components/omnibox/browser/autocomplete_input.cc

@@ -265,7 +265,7 @@ metrics::OmniboxInputType::Type AutocompleteInput::Parse(

// Check if the canonicalized host has a known TLD, which we'll want to know

// below.

const size_t registry_length =

- net::registry_controlled_domains::GetRegistryLength(

+ net::registry_controlled_domains::GetCanonicalHostRegistryLength(

canonicalized_url->host(),

net::registry_controlled_domains::EXCLUDE_UNKNOWN_REGISTRIES,

net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES);