net/cert/x509_certificate.cc - Issue 2446273004: Reduce buggy usage of the registry controlled domain service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate.cc

Issue 2446273004: Reduce buggy usage of the registry controlled domain service. (Closed)

Patch Set: Review comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_certificate.cc

diff --git a/net/cert/x509_certificate.cc b/net/cert/x509_certificate.cc

index 48cc5b5c8c509943151747cb8da85120c64ee2d8..7f23e7bf1d4d12b5447b576e1135f4ca7c8134f1 100644

--- a/net/cert/x509_certificate.cc

+++ b/net/cert/x509_certificate.cc

@@ -551,7 +551,7 @@ bool X509Certificate::VerifyHostname(

// is not registry controlled, this ensures that all reference domains

// contain at least three domain components when using wildcards.

size_t registry_length =

- registry_controlled_domains::GetRegistryLength(

+ registry_controlled_domains::GetCanonicalHostRegistryLength(

reference_name,

registry_controlled_domains::INCLUDE_UNKNOWN_REGISTRIES,

registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES);