components/ssl_errors/error_classification.h - Issue 2446273004: Reduce buggy usage of the registry controlled domain service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ssl_errors/error_classification.h

Issue 2446273004: Reduce buggy usage of the registry controlled domain service. (Closed)

Patch Set: Review comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ssl_errors/error_classification.h

diff --git a/components/ssl_errors/error_classification.h b/components/ssl_errors/error_classification.h

index 7da66fdd6cf5cd2070f7bc576fbb52bfd9373e4a..b8c472df6697f0607b8cd6b37185ed63fd3c3d9a 100644

--- a/components/ssl_errors/error_classification.h

+++ b/components/ssl_errors/error_classification.h

@@ -147,7 +147,7 @@ HostnameTokens Tokenize(const std::string& name);

void SetBuildTimeForTesting(const base::Time& testing_time);

// Returns true if the hostname has a known Top Level Domain.

-bool IsHostNameKnownTLD(const std::string& host_name);

+bool HostNameHasKnownTLD(const std::string& host_name);

// Returns true if any one of the following conditions hold:

// 1.|hostname| is an IP Address in an IANA-reserved range.