Issue 2445193003: Fix for LibraryDirective annotations while applying resynthesized element model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2445193003: Fix for LibraryDirective annotations while applying resynthesized element model. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for LibraryDirective annotations while applying resynthesized element model. This allows us to clean up the analysis driver. I will NOT land this without your review. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f797154673bff68115ef0a466d52d679b87d710d

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -24 lines)			Patch
M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	2 chunks	+0 lines, -22 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/declaration_resolver.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/generated/declaration_resolver_test.dart	View	2 chunks	+15 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as f797154673bff68115ef0a466d52d679b87d710d (presubmit successful).

4 years, 1 month ago (2016-10-26 14:40:13 UTC) #4

Message was sent while issue was closed.

lgtm