Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: pkg/analyzer/test/generated/declaration_resolver_test.dart

Issue 2445193003: Fix for LibraryDirective annotations while applying resynthesized element model. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/declaration_resolver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/declaration_resolver_test.dart
diff --git a/pkg/analyzer/test/generated/declaration_resolver_test.dart b/pkg/analyzer/test/generated/declaration_resolver_test.dart
index 74232ac7fe5404d111812d73fe3e78a3e8b147fc..32927b0d630076e8f208321748aa9745ee3bbe96 100644
--- a/pkg/analyzer/test/generated/declaration_resolver_test.dart
+++ b/pkg/analyzer/test/generated/declaration_resolver_test.dart
@@ -8,6 +8,7 @@ import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/dart/ast/ast.dart';
import 'package:analyzer/src/dart/ast/utilities.dart';
+import 'package:analyzer/src/dart/element/element.dart';
import 'package:analyzer/src/generated/declaration_resolver.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -167,6 +168,20 @@ class DeclarationResolverMetadataTest extends ResolverTestCase {
checkMetadata('L');
}
+ void test_metadata_libraryDirective_resynthesized() {
+ CompilationUnit unit = resolveSource('@a library L; const a = null;');
+ expect(unit.directives.single.metadata.single.name.name, 'a');
+ var unitElement = unit.element as CompilationUnitElementImpl;
+ // Damage the unit element - as if "setAnnotations" were not called.
+ // The LibraryElement still has the metadata, we should use it.
+ unitElement.setAnnotations(unit.directives.single.offset, []);
+ expect(unitElement.library.metadata, hasLength(1));
+ // DeclarationResolver on the clone should succeed.
+ CompilationUnit clonedUnit = AstCloner.clone(unit);
+ new DeclarationResolver().resolve(clonedUnit, unit.element);
+ expect(clonedUnit.directives.single.metadata.single.name.name, 'a');
+ }
+
void test_metadata_localFunctionDeclaration() {
setupCode('f() { @a g() {} }');
// Note: metadata on local function declarations is ignored by the
« no previous file with comments | « pkg/analyzer/lib/src/generated/declaration_resolver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698