Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/driver.dart

Issue 2445193003: Fix for LibraryDirective annotations while applying resynthesized element model. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/declaration_resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/analysis/driver.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/driver.dart b/pkg/analyzer/lib/src/dart/analysis/driver.dart
index 701e2e552e32e6e11c78994b1764e745e1346c19..d140185e8d6f7de948227b9156474fe3969b39dd 100644
--- a/pkg/analyzer/lib/src/dart/analysis/driver.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/driver.dart
@@ -326,26 +326,6 @@ class AnalysisDriver {
* Compute the [AnalysisResult] for the [file].
*/
AnalysisResult _computeAnalysisResult(_File file) {
- // TODO(scheglov) Computing resolved unit fails for these units.
- // pkg/analyzer/lib/plugin/embedded_resolver_provider.dart
- // pkg/analyzer/lib/plugin/embedded_resolver_provider.dart
- if (file.path.endsWith(
- 'pkg/analyzer/lib/plugin/embedded_resolver_provider.dart') ||
- file.path.endsWith('pkg/analyzer/lib/source/embedder.dart') ||
- file.path.endsWith('pkg/analyzer/lib/src/generated/ast.dart') ||
- file.path.endsWith('pkg/analyzer/lib/src/generated/element.dart') ||
- file.path
- .endsWith('pkg/analyzer/lib/src/generated/element_handle.dart') ||
- file.path.endsWith('pkg/analyzer/lib/src/generated/error.dart') ||
- file.path.endsWith('pkg/analyzer/lib/src/generated/scanner.dart') ||
- file.path.endsWith('pkg/analyzer/lib/src/generated/sdk_io.dart') ||
- file.path.endsWith('pkg/analyzer/lib/src/generated/visitors.dart') ||
- file.path.endsWith('pkg/analyzer/test/generated/constant_test.dart') ||
- file.path.endsWith('pkg/analyzer/test/source/embedder_test.dart')) {
- return new AnalysisResult(
- file.path, file.uri, null, file.contentHash, null, []);
- }
-
return _logger.run('Compute analysis result for $file', () {
_LibraryContext libraryContext = _createLibraryContext(file);
AnalysisContext analysisContext = _createAnalysisContext(libraryContext);
@@ -537,8 +517,6 @@ class AnalysisDriver {
/**
* Verify the API signatures for the changed files, and decide which linked
* libraries should be invalidated, and files reanalyzed.
- *
- * TODO(scheglov) I see that adding a local var changes (full) API signature.
*/
void _verifyUnlinkedSignatureOfChangedFiles() {
if (_filesToVerifyUnlinkedSignature.isEmpty) {
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/declaration_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698