Fix for LibraryDirective annotations while applying resynthesized element model.

pkg/analyzer/lib/src/dart/analysis/driver.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
@@ skipping 308 matching lines @@
    */
   void _addToStoreUnlinked(
       SummaryDataStore store, String uri, UnlinkedUnit unlinked) {
     store.unlinkedMap[uri] = unlinked;
   }
 
   /**
    * Compute the [AnalysisResult] for the [file].
    */
   AnalysisResult _computeAnalysisResult(_File file) {
-    // TODO(scheglov) Computing resolved unit fails for these units.
-    // pkg/analyzer/lib/plugin/embedded_resolver_provider.dart
-    // pkg/analyzer/lib/plugin/embedded_resolver_provider.dart
-    if (file.path.endsWith(
-            'pkg/analyzer/lib/plugin/embedded_resolver_provider.dart') ||
-        file.path.endsWith('pkg/analyzer/lib/source/embedder.dart') ||
-        file.path.endsWith('pkg/analyzer/lib/src/generated/ast.dart') ||
-        file.path.endsWith('pkg/analyzer/lib/src/generated/element.dart') ||
-        file.path
-            .endsWith('pkg/analyzer/lib/src/generated/element_handle.dart') ||
-        file.path.endsWith('pkg/analyzer/lib/src/generated/error.dart') ||
-        file.path.endsWith('pkg/analyzer/lib/src/generated/scanner.dart') ||
-        file.path.endsWith('pkg/analyzer/lib/src/generated/sdk_io.dart') ||
-        file.path.endsWith('pkg/analyzer/lib/src/generated/visitors.dart') ||
-        file.path.endsWith('pkg/analyzer/test/generated/constant_test.dart') ||
-        file.path.endsWith('pkg/analyzer/test/source/embedder_test.dart')) {
-      return new AnalysisResult(
-          file.path, file.uri, null, file.contentHash, null, []);
-    }
-
     return _logger.run('Compute analysis result for $file', () {
       _LibraryContext libraryContext = _createLibraryContext(file);
       AnalysisContext analysisContext = _createAnalysisContext(libraryContext);
       analysisContext.setContents(file.source, file.content);
       // TODO(scheglov) Add support for parts.
       CompilationUnit resolvedUnit =
           analysisContext.resolveCompilationUnit2(file.source, file.source);
       List<AnalysisError> errors = analysisContext.computeErrors(file.source);
       return new AnalysisResult(file.path, file.uri, file.content,
           file.contentHash, resolvedUnit, errors);
@@ skipping 171 matching lines @@
               file.uri.toString(), unlinkedUnit, key);
           List<int> bytes = assembler.assemble().toBuffer();
           _byteStore.put(key, bytes);
           return new PackageBundle.fromBuffer(bytes);
         });
   }
 
   /**
    * Verify the API signatures for the changed files, and decide which linked
    * libraries should be invalidated, and files reanalyzed.
-   *
-   * TODO(scheglov) I see that adding a local var changes (full) API signature.
    */
   void _verifyUnlinkedSignatureOfChangedFiles() {
     if (_filesToVerifyUnlinkedSignature.isEmpty) {
       return;
     }
     int numOfFiles = _filesToVerifyUnlinkedSignature.length;
     _logger.run('Verify API signatures of $numOfFiles files', () {
       for (String path in _filesToVerifyUnlinkedSignature) {
         _File file = _fileForPath(path);
         // Get the existing old API signature, maybe null.
@@ skipping 422 matching lines @@
       }
     }
     for (UnlinkedExportPublic export in unit.publicNamespace.exports) {
       referenced.exported.add(export.uri);
     }
     return referenced;
   }
 
   _ReferencedUris._();
 }