Add xmllite and xmpp sources to third_party/

Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Update includes from webrtc/ to third_party/webrtc
* Update includes of webrtc/base/logging.h to third_party/webrtc_overrides/webrtc/base/logging.h
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539
Committed: https://crrev.com/f0e410bf18db180922731558988444de57b3102b
Cr-Commit-Position: refs/heads/master@{#441371}

[kjellander_chromium, 2016-10-24 20:52:24]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Deployment plan:
* Eliminate last dependencies on this code in WebRTC + roll
* Land this CL.
* Remove the code in WebRTC + roll

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.
* Added remoting/protocol/OWNERS as suggested by presubmit check.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Deployment plan:
* Eliminate last dependencies on this code in WebRTC
  (https://codereview.chromium.org/2447533003) + roll into DEPS
* Land this CL.
* Remove the code in WebRTC

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.
* Added remoting/protocol/OWNERS as suggested by presubmit check.

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-10-25 08:26:26]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Deployment plan:
* Eliminate last dependencies on this code in WebRTC
  (https://codereview.chromium.org/2447533003) + roll into DEPS
* Land this CL.
* Remove the code in WebRTC

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.
* Added remoting/protocol/OWNERS as suggested by presubmit check.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.
* Added remoting/protocol/OWNERS as suggested by presubmit check.

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-12-20 12:21:54]

kjellander@chromium.org changed reviewers:
+ nisse@chromium.org

[kjellander_chromium, 2016-12-20 12:22:41]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.
* Added remoting/protocol/OWNERS as suggested by presubmit check.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.
* Added remoting/protocol/OWNERS as suggested by presubmit check.

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-12-20 12:23:35]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.
* Added remoting/protocol/OWNERS as suggested by presubmit check.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-12-20 12:48:28]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc
* Formatted all the code using 'git cl format'.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-12-20 13:28:17]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Deleted obviously dead code:
  third_party/xmpp/chatroommodule_unittest.cc
* Updated license headers to Chromium license.
* Fixed too long lines in
  third_party/xmpp/chatroommodule.h
  third_party/xmpp/chatroommoduleimpl.cc

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Updated license headers to Chromium license.

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-12-20 14:03:55]

Can you see what's wrong?

[nisse-chromium (ooo August 14), 2016-12-20 14:55:11]

On 2016/12/20 14:03:55, kjellander_chromium wrote:
> Can you see what's wrong?

It seems the failing command line, to compile login.cc, picks up
third_party/webrtc/base/logging.h, when it's supposed to pick up
third_party/webrtc_overrides/webrtc/base/logging.h. The directories 
are listed multiple times on the command line, in this order:

-I../../third_party/webrtc_overrides
-I../../third_party
-I../../third_party/webrtc_overrides
-I../../third_party

I think the first one should win, but I'm not 100% sure. To
investigate, I'd try compiling with -E or -save-temps, and
examine the #line directives in the preprocessed file to see
which #include gets the wrong file.

[nisse-chromium (ooo August 14), 2016-12-20 15:00:45]

https://codereview.chromium.org/2443903004/diff/60001/jingle/BUILD.gn
File jingle/BUILD.gn (right):

https://codereview.chromium.org/2443903004/diff/60001/jingle/BUILD.gn#newcode102
jingle/BUILD.gn:102: "//third_party/libjingle",
I think it should still depend on third_party/webrtc/something, since the code
still includes some webrtc headers?

[nisse-chromium (ooo August 14), 2016-12-20 15:16:40]

On 2016/12/20 15:00:45, nisse-chromium wrote:
> https://codereview.chromium.org/2443903004/diff/60001/jingle/BUILD.gn
> File jingle/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2443903004/diff/60001/jingle/BUILD.gn#newcode102
> jingle/BUILD.gn:102: "//third_party/libjingle",
> I think it should still depend on third_party/webrtc/something, since the code
> still includes some webrtc headers?

I think I've spotted the problem. In xmppclient.cc, webrtc includes are written
like

#include "third_party/webrtc/base/logging.h"
#include "third_party/webrtc/base/sigslot.h"
#include "third_party/webrtc/base/stringutils.h"

This can never pick up anything under third_party/webrtc_overrides/.

The logging.h h line must be changed either to

#include "webrtc/base/logging.h" // Rely on -I flags

or 

#include "third_party/webrtc_overrides/webrtc/base/logging.h" // Chrome specific

No idea if either alternative really fits with the way the overrides-mechanism
works.

Ideally, xmpp shouldn't depend on webrtc at all, I guess.

[Sergey Ulanov, 2016-12-20 20:36:36]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-12-20 20:36:39]

Thank you!

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmllite/RE...
File third_party/xmllite/README.chromium (right):

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmllite/RE...
third_party/xmllite/README.chromium:1: Name: WebRTC
This doesn't looks like correct description. If I understand correctly xmllite
will no longer live in webrtc going forward, so I think this file should be
clear about it.

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/BUILD.gn
File third_party/xmpp/BUILD.gn (right):

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/BUILD...
third_party/xmpp/BUILD.gn:1: # Copyright 2016 The Chromium Authors. All rights
reserved.
I'm not sure we need to separate directories in third_party. Also
third_party/xmpp may be confusing: XMPP is a protocol, not a library. Maybe add
one directory (e.g. third_party/libjingle_xmpp) that would contain both xmllite
and xmpp parts?

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNERS
File third_party/xmpp/OWNERS (right):

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNER...
third_party/xmpp/OWNERS:1: henrika@webrtc.org
Please use @chromium.org addresses. Also all owners must be chromium committers
and not everyone on this list is a committer

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNER...
third_party/xmpp/OWNERS:4: jiayl@webrtc.org
jiayl@ no longer works on chromium/webrtc, so she shouldn't be in the owners
list.

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/READM...
File third_party/xmpp/README.chromium (right):

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/READM...
third_party/xmpp/README.chromium:1: Name: WebRTC
Same as in xmllite/README.chromium . This file should make it clear that this
directory contains fork of XMPP feature that was previously in libjingle/webrtc.

[kjellander_chromium, 2016-12-20 20:49:56]

Oh, this wasn't really ready for review just yet, I was aware of the
README.chromium needed an update.
Thanks to nisse@ I got this compiling now. I'll address the rest in a new patch
set tomorrow.

On 2016/12/20 20:36:39, Sergey Ulanov wrote:
> Thank you!
> 
>
https://codereview.chromium.org/2443903004/diff/100001/third_party/xmllite/RE...
> File third_party/xmllite/README.chromium (right):
> 
>
https://codereview.chromium.org/2443903004/diff/100001/third_party/xmllite/RE...
> third_party/xmllite/README.chromium:1: Name: WebRTC
> This doesn't looks like correct description. If I understand correctly xmllite
> will no longer live in webrtc going forward, so I think this file should be
> clear about it.
> 
>
https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/BUILD.gn
> File third_party/xmpp/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/BUILD...
> third_party/xmpp/BUILD.gn:1: # Copyright 2016 The Chromium Authors. All rights
> reserved.
> I'm not sure we need to separate directories in third_party. Also
> third_party/xmpp may be confusing: XMPP is a protocol, not a library. Maybe
add
> one directory (e.g. third_party/libjingle_xmpp) that would contain both
xmllite
> and xmpp parts?
> 
> https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNERS
> File third_party/xmpp/OWNERS (right):
> 
>
https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNER...
> third_party/xmpp/OWNERS:1: mailto:henrika@webrtc.org
> Please use @chromium.org addresses. Also all owners must be chromium
committers
> and not everyone on this list is a committer
> 
>
https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNER...
> third_party/xmpp/OWNERS:4: mailto:jiayl@webrtc.org
> jiayl@ no longer works on chromium/webrtc, so she shouldn't be in the owners
> list.
> 
>
https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/READM...
> File third_party/xmpp/README.chromium (right):
> 
>
https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/READM...
> third_party/xmpp/README.chromium:1: Name: WebRTC
> Same as in xmllite/README.chromium . This file should make it clear that this
> directory contains fork of XMPP feature that was previously in
libjingle/webrtc.

[kjellander_chromium, 2016-12-21 14:44:16]

kjellander@chromium.org changed reviewers:
+ pthatcher@chromium.org

[kjellander_chromium, 2016-12-21 14:45:01]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/xmllite and third_party/xmpp are updated
  to reflect the new absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Updated license headers to Chromium license.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Updated license headers to Chromium license.

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-12-21 14:46:23]

+pthatcher. Peter can you have a look at the README.chromium and LICENSE file?

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmllite/RE...
File third_party/xmllite/README.chromium (right):

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmllite/RE...
third_party/xmllite/README.chromium:1: Name: WebRTC
On 2016/12/20 20:36:38, Sergey Ulanov wrote:
> This doesn't looks like correct description. If I understand correctly xmllite
> will no longer live in webrtc going forward, so I think this file should be
> clear about it. 

Covered in the updated one.

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/BUILD.gn
File third_party/xmpp/BUILD.gn (right):

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/BUILD...
third_party/xmpp/BUILD.gn:1: # Copyright 2016 The Chromium Authors. All rights
reserved.
On 2016/12/20 20:36:38, Sergey Ulanov wrote:
> I'm not sure we need to separate directories in third_party. Also
> third_party/xmpp may be confusing: XMPP is a protocol, not a library. Maybe
add
> one directory (e.g. third_party/libjingle_xmpp) that would contain both
xmllite
> and xmpp parts?

Good idea. I've done that in the new patch set.

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNERS
File third_party/xmpp/OWNERS (right):

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNER...
third_party/xmpp/OWNERS:1: henrika@webrtc.org
On 2016/12/20 20:36:38, Sergey Ulanov wrote:
> Please use @chromium.org addresses. Also all owners must be chromium
committers
> and not everyone on this list is a committer

Done.

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/OWNER...
third_party/xmpp/OWNERS:4: jiayl@webrtc.org
On 2016/12/20 20:36:38, Sergey Ulanov wrote:
> jiayl@ no longer works on chromium/webrtc, so she shouldn't be in the owners
> list.

Done.

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/READM...
File third_party/xmpp/README.chromium (right):

https://codereview.chromium.org/2443903004/diff/100001/third_party/xmpp/READM...
third_party/xmpp/README.chromium:1: Name: WebRTC
On 2016/12/20 20:36:38, Sergey Ulanov wrote:
> Same as in xmllite/README.chromium . This file should make it clear that this
> directory contains fork of XMPP feature that was previously in
libjingle/webrtc.

I did a best effort update in the new patch set. Will ask pthatcher for advice.

[kjellander_chromium, 2016-12-21 14:46:35]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 14:46:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 14:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 14:52:12]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kjellander_chromium, 2016-12-21 21:39:31]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 21:39:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 22:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 22:47:59]

Dry run: This issue passed the CQ dry run.

[pthatcher2, 2016-12-22 20:33:30]

lgtm

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
File third_party/libjingle_xmpp/xmllite/BUILD.gn (right):

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
third_party/libjingle_xmpp/xmllite/BUILD.gn:74:
"//third_party/webrtc/base:rtc_base_tests_utils",
It's a little unfortunate that this depends on webrtc/base.  Do you think it
would be worth it to copy the relevant files from webrtc/base to
libjingle_xmpp/base?  I noticed these files that it needs:

"webrtc/base/socketaddress.h"
"webrtc/base/sigslot.h"
"webrtc/base/task.h"
"webrtc/base/common.h"
"webrtc/base/firewallsocketserver.h"
"webrtc/base/logging.h"
"webrtc/base/physicalsocketserver.h"
"webrtc/base/taskrunner.h"


This could be done in a follow-up CL, though.

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
File third_party/libjingle_xmpp/xmpp/DEPS (right):

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
third_party/libjingle_xmpp/xmpp/DEPS:4: "+webrtc/p2p",
I noticed this really only exists for the cricket::ProtocolType enum.  It might
make sense to put that in libjingle_xmpp and avoid this dependency.  

But, again, that could go in a followup CL.

[pthatcher2, 2016-12-22 20:34:01]

This is great, by the way.  I love to see that it's happening.

[Sergey Ulanov, 2016-12-22 22:57:59]

https://codereview.chromium.org/2443903004/diff/140001/remoting/protocol/DEPS
File remoting/protocol/DEPS (right):

https://codereview.chromium.org/2443903004/diff/140001/remoting/protocol/DEPS...
remoting/protocol/DEPS:11: "+third_party/libjingle",
remove this?

https://codereview.chromium.org/2443903004/diff/140001/remoting/protocol/DEPS...
remoting/protocol/DEPS:14: "+third_party/libjingle_xmpp/xmpp",
sort alphabetically

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
File third_party/libjingle_xmpp/README.chromium (right):

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
third_party/libjingle_xmpp/README.chromium:1: Name: xmllite
This directory also contains XMPP now, so this name/description do not look
right.

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
File third_party/libjingle_xmpp/xmllite/qname.h (right):

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
third_party/libjingle_xmpp/xmllite/qname.h:1: // Copyright 2004 The Chromium
Authors. All rights reserved.
I think the right thing to do here is to keep the old copyright headers from
WebRTC.
It looks like some files have old headers, while others have it replaced by the
chromium header. Was that intentional?

[kjellander_chromium, 2016-12-27 11:57:48]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 11:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-12-27 12:49:21]

Good news: I spent more time on this and realized we don't need to add the XMPP
code that isn't used by Chromium:
https://cs.chromium.org/chromium/src/third_party/webrtc/libjingle/xmpp/BUILD....

so I dropped those sources + their unit tests in PS#9. That brings down the
number of added lines from 19542 to 10202 in this CL!

The removed sources between patch set 8 and 9 are (I also moved the BUILD.gn so
it's hard to see):
chatroommodule.h
chatroommoduleimpl.cc
discoitemsquerytask.cc
discoitemsquerytask.h
hangoutpubsubclient.cc
hangoutpubsubclient.h
iqtask.cc
iqtask.h
module.h
moduleimpl.cc
moduleimpl.h
mucroomconfigtask.cc
mucroomconfigtask.h
mucroomconfigtask_unittest.cc
mucroomdiscoverytask.cc
mucroomdiscoverytask.h
mucroomdiscoverytask_unittest.cc
mucroomlookuptask.cc
mucroomlookuptask.h
mucroomlookuptask_unittest.cc
mucroomuniquehangoutidtask.cc
mucroomuniquehangoutidtask.h
mucroomuniquehangoutidtask_unittest.cc
pingtask.cc
pingtask.h
pingtask_unittest.cc
presenceouttask.cc
presenceouttask.h
presencereceivetask.cc
presencereceivetask.h
presencestatus.cc
presencestatus.h
pubsub_task.cc
pubsub_task.h
pubsubclient.cc
pubsubclient.h
pubsubclient_unittest.cc
pubsubstateclient.cc
pubsubstateclient.h
pubsubtasks.cc
pubsubtasks.h
pubsubtasks_unittest.cc
receivetask.cc
receivetask.h
rostermodule.h
rostermoduleimpl.cc
rostermoduleimpl.h
xmppauth.cc
xmppauth.h
xmpppump.cc
xmpppump.h
xmppsocket.cc
xmppsocket.h
xmppthread.cc
xmppthread.h

I also created a libjingle_xmpp_unittests target to keep all the tests and
created a
run_all_unittests.cc to get a main() for it. The 95 tests execute in ~0.02s.
I'll try to get this test added to the bots later on.

I posted a comment about the follow-up work suggested by pthatcher in the bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5539

https://codereview.chromium.org/2443903004/diff/140001/remoting/protocol/DEPS
File remoting/protocol/DEPS (right):

https://codereview.chromium.org/2443903004/diff/140001/remoting/protocol/DEPS...
remoting/protocol/DEPS:11: "+third_party/libjingle",
On 2016/12/22 22:57:59, Sergey Ulanov wrote:
> remove this?

Yes!

https://codereview.chromium.org/2443903004/diff/140001/remoting/protocol/DEPS...
remoting/protocol/DEPS:14: "+third_party/libjingle_xmpp/xmpp",
On 2016/12/22 22:57:58, Sergey Ulanov wrote:
> sort alphabetically

Done.

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
File third_party/libjingle_xmpp/README.chromium (right):

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
third_party/libjingle_xmpp/README.chromium:1: Name: xmllite
On 2016/12/22 22:57:59, Sergey Ulanov wrote:
> This directory also contains XMPP now, so this name/description do not look
> right.

Sorry that was sloppy. I started with one per dir but then moved them according
to your suggestion. Updated now.

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
File third_party/libjingle_xmpp/xmllite/BUILD.gn (right):

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
third_party/libjingle_xmpp/xmllite/BUILD.gn:74:
"//third_party/webrtc/base:rtc_base_tests_utils",
On 2016/12/22 20:33:29, pthatcher2 wrote:
> It's a little unfortunate that this depends on webrtc/base.  Do you think it
> would be worth it to copy the relevant files from webrtc/base to
> libjingle_xmpp/base?  I noticed these files that it needs:
> 
> "webrtc/base/socketaddress.h"
> "webrtc/base/sigslot.h"
> "webrtc/base/task.h"
> "webrtc/base/common.h"
> "webrtc/base/firewallsocketserver.h"
> "webrtc/base/logging.h"
> "webrtc/base/physicalsocketserver.h"
> "webrtc/base/taskrunner.h"
> 
> 
> This could be done in a follow-up CL, though.

Yeah, let's do that in follow-up. I posted a note in the bug about this as well.

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
File third_party/libjingle_xmpp/xmllite/qname.h (right):

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
third_party/libjingle_xmpp/xmllite/qname.h:1: // Copyright 2004 The Chromium
Authors. All rights reserved.
On 2016/12/22 22:57:59, Sergey Ulanov wrote:
> I think the right thing to do here is to keep the old copyright headers from
> WebRTC.
> It looks like some files have old headers, while others have it replaced by
the
> chromium header. Was that intentional?

You're probably right, I changed to Chromium headers in my previous attempt to
put the sources into src/jingle. I've restored all the headers to WebRTC headers
now.

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
File third_party/libjingle_xmpp/xmpp/DEPS (right):

https://codereview.chromium.org/2443903004/diff/140001/third_party/libjingle_...
third_party/libjingle_xmpp/xmpp/DEPS:4: "+webrtc/p2p",
On 2016/12/22 20:33:30, pthatcher2 wrote:
> I noticed this really only exists for the cricket::ProtocolType enum.  It
might
> make sense to put that in libjingle_xmpp and avoid this dependency.  
> 
> But, again, that could go in a followup CL.

Yeah, let's do those cleanups in a follow-up CL. I've posted some notes in the
bug to keep such tasks more visible.

[commit-bot: I haz the power, 2016-12-27 13:28:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 13:28:41]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Sergey Ulanov, 2016-12-27 19:51:21]

LGTM! Thank you!

[pthatcher2, 2016-12-27 21:50:35]

lgtm++

[kjellander_chromium, 2016-12-28 12:59:17]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Added DEPS file in each folder, to restrict includes.
* Updated license headers to Chromium license.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-12-28 13:02:23]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539
==========

[kjellander_chromium, 2016-12-28 14:08:03]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 14:08:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-12-28 14:08:30]

kjellander@chromium.org changed reviewers:
+ dpranke@chromium.org

[kjellander_chromium, 2016-12-28 14:08:31]

+dpranke for third_party OWNERS approval.

[commit-bot: I haz the power, 2016-12-28 15:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 15:22:26]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-01-04 03:00:37]

I am not a third_party owner, unfortunately (fortunately)? 

Though I perhaps should be ...

[kjellander_chromium, 2017-01-04 06:14:44]

kjellander@chromium.org changed reviewers:
+ jochen@chromium.org

[kjellander_chromium, 2017-01-04 06:14:46]

My mistake Dirk, sorry 'bout that.

+jochen for third_party OWNERS then.

[jochen (gone - plz use gerrit), 2017-01-04 06:57:22]

lgtm

[kjellander_chromium, 2017-01-04 07:55:26]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2017-01-04 07:55:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, pthatcher@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2443903004/#ps240001
(title: "Rebased")

[commit-bot: I haz the power, 2017-01-04 07:55:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 08:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 08:05:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kjellander_chromium, 2017-01-04 08:09:13]

kjellander@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, tommi@chromium.org

[kjellander_chromium, 2017-01-04 08:10:02]

+phajdan.jr for testing/ OWNERS (since 	third_party/libjingle_xmpp/DEPS
references testing/ in order to get the unit test binary to build).

+tommi for webrtc/ reference in DEPS.

[tommi (sloooow) - chröme, 2017-01-04 08:49:45]

lgtm! great work Henrik :)

[Paweł Hajdan Jr., 2017-01-04 11:35:18]

LGTM

[kjellander_chromium, 2017-01-04 11:35:55]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2017-01-04 11:36:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 11:44:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 11:44:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kjellander_chromium, 2017-01-04 12:42:11]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2017-01-04 12:42:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
sergeyu@chromium.org, pthatcher@chromium.org, phajdan.jr@chromium.org,
tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2443903004/#ps260001
(title: "Update includes to use third_party/webrtc")

[commit-bot: I haz the power, 2017-01-04 12:42:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 12:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 12:50:29]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[kjellander_chromium, 2017-01-04 13:50:43]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Update includes from webrtc/ to third_party/webrtc
* Update includes of webrtc/base/logging.h to
third_party/webrtc_overrides/webrtc/base/logging.h
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539
==========

[kjellander_chromium, 2017-01-04 13:51:36]

On 2017/01/04 12:50:29, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

PS#14 and 15 changed the following: 
* Update includes from webrtc/ to third_party/webrtc + DEPS rules.
* Update includes of webrtc/base/logging.h to
third_party/webrtc_overrides/webrtc/base/logging.h due to the above.

[kjellander_chromium, 2017-01-04 13:51:47]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2017-01-04 13:51:48]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
sergeyu@chromium.org, pthatcher@chromium.org, phajdan.jr@chromium.org,
tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2443903004/#ps280001
(title: "Explicitly use webrtc_overrides/webrtc/base/logging.h")

[commit-bot: I haz the power, 2017-01-04 13:52:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 14:45:06]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1483537907425990,
"parent_rev": "48f527d7bce21b49ec5b760bdeeb3891edd07820", "commit_rev":
"64e65485d38adf2e66062f1214b4bdf6ad60183a"}

[commit-bot: I haz the power, 2017-01-04 14:45:33]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Update includes from webrtc/ to third_party/webrtc
* Update includes of webrtc/base/logging.h to
third_party/webrtc_overrides/webrtc/base/logging.h
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Update includes from webrtc/ to third_party/webrtc
* Update includes of webrtc/base/logging.h to
third_party/webrtc_overrides/webrtc/base/logging.h
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539

Review-Url: https://codereview.chromium.org/2443903004
==========

[commit-bot: I haz the power, 2017-01-04 14:45:35]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2017-01-04 14:47:29]

Description was changed from

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Update includes from webrtc/ to third_party/webrtc
* Update includes of webrtc/base/logging.h to
third_party/webrtc_overrides/webrtc/base/logging.h
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539

Review-Url: https://codereview.chromium.org/2443903004
==========

to

==========
Add xmllite and xmpp sources to third_party/

Add third_party/xmllite and third_party/xmpp source repos,
which used to be located in third_party/webrtc/libjingle since
the code is no longer used by WebRTC; only Chromium.

Modifications made:
* Include paths in jingle/ and remoting/ are updated to reflect
  the new location of xmllite and xmpp.
* Include paths in third_party/libjingle_xmpp/xmllite and
  third_party/libjingle_xmpp/xmpp are updated to reflect the new
  absolute paths to their own headers.
* Update previous include paths using non-absolute paths referencing
  "webrtc/libjingle/xmpp" to third_party/libjingle_xmpp/xmpp.
* Update includes from webrtc/ to third_party/webrtc
* Update includes of webrtc/base/logging.h to
third_party/webrtc_overrides/webrtc/base/logging.h
* Added DEPS file in each folder, to restrict includes.

BUG=webrtc:5539

Committed: https://crrev.com/f0e410bf18db180922731558988444de57b3102b
Cr-Commit-Position: refs/heads/master@{#441371}
==========

[commit-bot: I haz the power, 2017-01-04 14:47:32]

Patchset 15 (id:??) landed as
https://crrev.com/f0e410bf18db180922731558988444de57b3102b
Cr-Commit-Position: refs/heads/master@{#441371}