third_party/libjingle_xmpp/xmpp/DEPS - Issue 2443903004: Add xmllite and xmpp sources to third_party/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libjingle_xmpp/xmpp/DEPS

Issue 2443903004: Add xmllite and xmpp sources to third_party/ (Closed)

Patch Set: Fix GN and sort includes Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+third_party/expat",

	3 "+webrtc/base",

	4 "+webrtc/p2p",
	pthatcher2 2016/12/22 20:33:30 I noticed this really only exists for the cricket: I noticed this really only exists for the cricket::ProtocolType enum. It might make sense to put that in libjingle_xmpp and avoid this dependency. But, again, that could go in a followup CL. kjellander_chromium 2016/12/27 12:49:21 Yeah, let's do those cleanups in a follow-up CL. I Show quoted text On 2016/12/22 20:33:30, pthatcher2 wrote: > I noticed this really only exists for the cricket::ProtocolType enum. It might > make sense to put that in libjingle_xmpp and avoid this dependency. > > But, again, that could go in a followup CL. Yeah, let's do those cleanups in a follow-up CL. I've posted some notes in the bug to keep such tasks more visible.
	5 ]

	6 specific_include_rules = {

	7 "xmpplogintask_unittest\.cc": [

	8 "+webrtc/typedefs.h",

	9 ],

	10 }

OLD	NEW