Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2447533003: Remove dead dependencies on xmllite and xmpp. (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dead dependencies on xmllite and xmpp. media/ and p2p/ doesn't actually depend on these anymore. BUG=webrtc:5539 NOTRY=True Committed: https://crrev.com/af1ae310ef61b7a82f8f5deaf25277aa5fd72ce1 Cr-Commit-Position: refs/heads/master@{#14761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
kjellander_webrtc
Monster CL in Chromium: https://codereview.chromium.org/2443903004/
4 years, 1 month ago (2016-10-24 20:54:03 UTC) #2
nisse-webrtc
There are still test targets in webrtc/BUILD.gn. You want to keep them for the time ...
4 years, 1 month ago (2016-10-25 06:42:53 UTC) #3
kjellander_webrtc
On 2016/10/25 06:42:53, nisse-webrtc wrote: > There are still test targets in webrtc/BUILD.gn. You want ...
4 years, 1 month ago (2016-10-25 07:02:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2447533003/1
4 years, 1 month ago (2016-10-25 08:25:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 08:27:14 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 08:27:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af1ae310ef61b7a82f8f5deaf25277aa5fd72ce1
Cr-Commit-Position: refs/heads/master@{#14761}

Powered by Google App Engine
This is Rietveld 408576698