[Payments] Show the icon for the typed in credit card in editor

Show the icon for the typed in credit card in editor

BUG=657178
Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Committed: https://crrev.com/fdf42fb9c2987cd86ac15e5963af0ad0f0153456
Cr-Original-Commit-Position: refs/heads/master@{#428359}
Cr-Commit-Position: refs/heads/master@{#428797}

[gogerald1, 2016-10-22 19:09:34]

Description was changed from

==========
draft

BUG=
==========

to

==========
Show the icon for the typed in credit card in editor

BUG=657178
==========

[gogerald1, 2016-10-24 14:12:42]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-10-24 14:12:48]

Patchset #1 (id:20001) has been deleted

[gogerald1, 2016-10-24 14:12:53]

Patchset #1 (id:40001) has been deleted

[gogerald1, 2016-10-24 14:23:01]

Patchset #1 (id:60001) has been deleted

[gogerald1, 2016-10-25 16:02:22]

Patchset #2 (id:100001) has been deleted

[gogerald1, 2016-10-25 16:02:26]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 16:02:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-25 16:09:22]

Patchset #1 (id:80001) has been deleted

[gogerald1, 2016-10-25 16:09:32]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 16:09:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 16:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 16:39:56]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-10-25 16:57:09]

Patchset #1 (id:120001) has been deleted

[gogerald1, 2016-10-25 16:57:17]

Patchset #1 (id:140001) has been deleted

[gogerald1, 2016-10-25 17:04:22]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 17:04:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-25 17:10:17]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org

[gogerald1, 2016-10-25 17:10:18]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org

[gogerald1, 2016-10-25 17:10:18]

Hi, PTAL,

[gogerald1, 2016-10-25 17:10:19]

Hi, PTAL,

[commit-bot: I haz the power, 2016-10-25 17:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:37:33]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-10-25 17:48:18]

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:41:
*/
Comment indentation

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:47:
*/
Ditto

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:122:
@Nullable private Runnable mActionIconAction;
Why this rename?

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:299:
* @return The icon resource Id for the value in this field.
This whole comment can fit on the same line:

/** @return The icon resource identifier for the value in this field. */

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:306:
return 0;
Yo can reduce the number of lines here:

return mValueIconGenerator == null ? 0 :
mValueIconGenerator.getIconResourceId(mValue);

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
(right):

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:40:
private int mValueIconId = 0;
0 is the default value for Java ints, so there's no need to explicitly assign 0
to this variable.

https://codereview.chromium.org/2442933003/diff/160001/chrome/browser/autofil...
File chrome/browser/autofill/android/personal_data_manager_android.cc (right):

https://codereview.chromium.org/2442933003/diff/160001/chrome/browser/autofil...
chrome/browser/autofill/android/personal_data_manager_android.cc:509:
.basic_card_payment_type);
You can reduce the number of lines by 1 here. Up to you which style you prefer.

  return ConvertUTF8ToJavaString(
      env, static_cast<bool>(jempty_if_invalid) &&
                   !IsValidCreditCardNumber(card_number)
               ? ""
               : data_util::GetPaymentRequestData(
                     CreditCard::GetCreditCardType(card_number))
                     .basic_card_payment_type);

[gogerald1, 2016-10-26 15:22:16]

gogerald@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mathp@chromium.org

[gogerald1, 2016-10-26 15:22:17]

mathp@chromium.org: Please review changes in 

chrome/browser/autofill/*

dfalcantara@chromium.org: Please review changes in 

chrome/android/*

Note that I've updated the interface to enable value icon in construction align
with action icon. In addition, if both icons are gone in the linearlayout before
layout, then I can not easily enable it later.

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:41:
*/
On 2016/10/25 17:48:18, rouslan wrote:
> Comment indentation

Done.

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:47:
*/
On 2016/10/25 17:48:18, rouslan wrote:
> Ditto

Done.

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:122:
@Nullable private Runnable mActionIconAction;
On 2016/10/25 17:48:18, rouslan wrote:
> Why this rename?

Now there are two icons may display at the same time, so I want distinguish it
by 'ActionIcon' and 'ValueIcon'.

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:299:
* @return The icon resource Id for the value in this field.
On 2016/10/25 17:48:18, rouslan wrote:
> This whole comment can fit on the same line:
> 
> /** @return The icon resource identifier for the value in this field. */

Done.

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:306:
return 0;
On 2016/10/25 17:48:18, rouslan wrote:
> Yo can reduce the number of lines here:
> 
> return mValueIconGenerator == null ? 0 :
> mValueIconGenerator.getIconResourceId(mValue);

Done. The implementation changed.

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
(right):

https://codereview.chromium.org/2442933003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:40:
private int mValueIconId = 0;
On 2016/10/25 17:48:18, rouslan wrote:
> 0 is the default value for Java ints, so there's no need to explicitly assign
0
> to this variable.

Done.

https://codereview.chromium.org/2442933003/diff/160001/chrome/browser/autofil...
File chrome/browser/autofill/android/personal_data_manager_android.cc (right):

https://codereview.chromium.org/2442933003/diff/160001/chrome/browser/autofil...
chrome/browser/autofill/android/personal_data_manager_android.cc:509:
.basic_card_payment_type);
On 2016/10/25 17:48:18, rouslan wrote:
> You can reduce the number of lines by 1 here. Up to you which style you
prefer.
> 
>   return ConvertUTF8ToJavaString(
>       env, static_cast<bool>(jempty_if_invalid) &&
>                    !IsValidCreditCardNumber(card_number)
>                ? ""
>                : data_util::GetPaymentRequestData(
>                      CreditCard::GetCreditCardType(card_number))
>                      .basic_card_payment_type);

Acknowledged. Looks more readable by separating them.

[gogerald1, 2016-10-26 15:22:23]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 15:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-10-26 15:29:22]

lgtm

[commit-bot: I haz the power, 2016-10-26 15:53:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:53:20]

Dry run: This issue passed the CQ dry run.

[gone, 2016-10-26 17:22:52]

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
File chrome/android/java/res/layout/payments_request_editor_textview.xml
(right):

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
chrome/android/java/res/layout/payments_request_editor_textview.xml:33:
android:layout_width="37.3dp"
We don't use a fractional DP anywhere in Clank because it'd make things blurry. 
I've poked the bug about it.

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
chrome/android/java/res/layout/payments_request_editor_textview.xml:36:
android:layout_marginBottom="12dp"
Instead of setting this margin top and bottom, can't you just set the gravity so
that it's vertically centered?

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
chrome/android/java/res/layout/payments_request_editor_textview.xml:37:
android:layout_marginStart="8dp"
This margin start should be on the parent layout instead because it really
applies to the whole layout and not just this control.

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
(right):

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:73:
mIconsLayer.getWidth(), mInput.getPaddingBottom());
getMeasuredWidth()?  I don't know if this call happens before or after the View
has properly been laid out, so getWidth() could return the wrong number.

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:253:
int iconId =
mEditorFieldModel.getValueIconGenerator().getIconResourceId(mInput.getText());
Can't getValueIconGenerator return null, in general?  I know that
getValueIconGenerator shouldn't be null if the mValueIcon isn't null in the
callers, but you should move that check into this function in case a new call
location is added.

[Mathieu, 2016-10-26 17:54:35]

autofill bits lgtm

[gogerald1, 2016-10-27 18:55:51]

Patchset #3 (id:200001) has been deleted

[gogerald1, 2016-10-27 19:01:36]

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
File chrome/android/java/res/layout/payments_request_editor_textview.xml
(right):

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
chrome/android/java/res/layout/payments_request_editor_textview.xml:33:
android:layout_width="37.3dp"
On 2016/10/26 17:22:51, dfalcantara (slow 10.24) wrote:
> We don't use a fractional DP anywhere in Clank because it'd make things
blurry. 
> I've poked the bug about it.

Keep it according to Hwi@'s feedback

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
chrome/android/java/res/layout/payments_request_editor_textview.xml:36:
android:layout_marginBottom="12dp"
On 2016/10/26 17:22:51, dfalcantara (slow 10.24) wrote:
> Instead of setting this margin top and bottom, can't you just set the gravity
so
> that it's vertically centered?

Done.

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
chrome/android/java/res/layout/payments_request_editor_textview.xml:37:
android:layout_marginStart="8dp"
On 2016/10/26 17:22:51, dfalcantara (slow 10.24) wrote:
> This margin start should be on the parent layout instead because it really
> applies to the whole layout and not just this control.

There might be a future situation that below action icon exist but this icon do
not exist. Then there is already 12dp padding in below icon (for layout and
touch space), we might do not want 8dp additional margin.

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
(right):

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:73:
mIconsLayer.getWidth(), mInput.getPaddingBottom());
On 2016/10/26 17:22:52, dfalcantara (slow 10.24) wrote:
> getMeasuredWidth()?  I don't know if this call happens before or after the
View
> has properly been laid out, so getWidth() could return the wrong number.

It happens after layout from the source code, 'public void layout(int l, int t,
int r, int b)' ->
https://github.com/android/platform_frameworks_base/blob/master/core/java/and...

I've also verified it through log.

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java:253:
int iconId =
mEditorFieldModel.getValueIconGenerator().getIconResourceId(mInput.getText());
On 2016/10/26 17:22:52, dfalcantara (slow 10.24) wrote:
> Can't getValueIconGenerator return null, in general?  I know that
> getValueIconGenerator shouldn't be null if the mValueIcon isn't null in the
> callers, but you should move that check into this function in case a new call
> location is added.

Done. moved if(mValueIcon == null) in this function.

[gone, 2016-10-27 20:14:42]

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
File chrome/android/java/res/layout/payments_request_editor_textview.xml
(right):

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
chrome/android/java/res/layout/payments_request_editor_textview.xml:33:
android:layout_width="37.3dp"
On 2016/10/27 19:01:35, gogerald1 wrote:
> On 2016/10/26 17:22:51, dfalcantara (slow 10.24) wrote:
> > We don't use a fractional DP anywhere in Clank because it'd make things
> blurry. 
> > I've poked the bug about it.
> 
> Keep it according to Hwi@'s feedback

Her feedback said she was crazy when she set it :P  Set it to 37.

[gogerald1, 2016-10-27 21:52:14]

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
File chrome/android/java/res/layout/payments_request_editor_textview.xml
(right):

https://codereview.chromium.org/2442933003/diff/180001/chrome/android/java/re...
chrome/android/java/res/layout/payments_request_editor_textview.xml:33:
android:layout_width="37.3dp"
On 2016/10/27 20:14:41, dfalcantara (slow 10.24) wrote:
> On 2016/10/27 19:01:35, gogerald1 wrote:
> > On 2016/10/26 17:22:51, dfalcantara (slow 10.24) wrote:
> > > We don't use a fractional DP anywhere in Clank because it'd make things
> > blurry. 
> > > I've poked the bug about it.
> > 
> > Keep it according to Hwi@'s feedback
> 
> Her feedback said she was crazy when she set it :P  Set it to 37.

After talking to Hwi@, the same icon will be used in two places for different
size and it is better to keep it's aspect ratio, so I set the height to 24dp and
auto scales it's width to keep aspect ratio.

[gone, 2016-10-27 21:52:52]

lgtm

[gogerald1, 2016-10-28 02:30:04]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 02:30:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-28 04:03:06]

The CQ bit was unchecked by gogerald@chromium.org

[gogerald1, 2016-10-28 04:03:17]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-10-28 04:03:18]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2442933003/#ps240001
(title: "auto scale icon width to keep aspect ratio")

[commit-bot: I haz the power, 2016-10-28 04:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 04:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 04:50:59]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gogerald1, 2016-10-28 04:51:57]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-10-28 04:52:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 06:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 06:18:23]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gogerald1, 2016-10-28 13:31:55]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-10-28 13:32:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 14:04:21]

Description was changed from

==========
Show the icon for the typed in credit card in editor

BUG=657178
==========

to

==========
Show the icon for the typed in credit card in editor

BUG=657178
==========

[commit-bot: I haz the power, 2016-10-28 14:04:23]

Committed patchset #4 (id:240001)

[commit-bot: I haz the power, 2016-10-28 14:06:33]

Description was changed from

==========
Show the icon for the typed in credit card in editor

BUG=657178
==========

to

==========
Show the icon for the typed in credit card in editor

BUG=657178

Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Cr-Commit-Position: refs/heads/master@{#428359}
==========

[commit-bot: I haz the power, 2016-10-28 14:06:34]

Patchset 4 (id:??) landed as
https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Cr-Commit-Position: refs/heads/master@{#428359}

[xidachen, 2016-10-28 17:39:38]

A revert of this CL (patchset #4 id:240001) has been created in
https://codereview.chromium.org/2456053007/ by xidachen@chromium.org.

The reason for reverting is: Cause test failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test....

[please use gerrit instead, 2016-10-31 18:25:35]

The reason for the assert failure.

https://codereview.chromium.org/2442933003/diff/240001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2442933003/diff/240001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:300:
assert mInputTypeHint == INPUT_TYPE_HINT_CREDIT_CARD;
This line really should be "assert isTextField();" because EditorTextField.java
checks every model for "getValueIconGenerator() != null".

[gogerald, 2016-10-31 18:57:54]

gogerald@google.com changed reviewers:
+ gogerald@google.com

[gogerald, 2016-10-31 18:57:55]

https://codereview.chromium.org/2442933003/diff/240001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2442933003/diff/240001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:300:
assert mInputTypeHint == INPUT_TYPE_HINT_CREDIT_CARD;
On 2016/10/31 18:25:35, rouslan wrote:
> This line really should be "assert isTextField();" because
EditorTextField.java
> checks every model for "getValueIconGenerator() != null".

Highly possible, relanding in this CL
https://codereview.chromium.org/2468603002/. Thanks for looking it :).

[gogerald1, 2016-10-31 19:11:37]

Description was changed from

==========
Show the icon for the typed in credit card in editor

BUG=657178

Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Cr-Commit-Position: refs/heads/master@{#428359}
==========

to

==========
Show the icon for the typed in credit card in editor

BUG=657178

Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Cr-Commit-Position: refs/heads/master@{#428359}
==========

[gogerald1, 2016-10-31 19:14:46]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 19:15:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 19:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:46:11]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-10-31 19:52:04]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-10-31 19:52:05]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
rouslan@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2442933003/#ps260001
(title: "fix assertion error and reland")

[gogerald1, 2016-10-31 19:52:19]

The CQ bit was unchecked by gogerald@chromium.org

[gogerald1, 2016-10-31 20:37:02]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:37:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:43:29]

Description was changed from

==========
Show the icon for the typed in credit card in editor

BUG=657178

Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Cr-Commit-Position: refs/heads/master@{#428359}
==========

to

==========
Show the icon for the typed in credit card in editor

BUG=657178

Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Cr-Commit-Position: refs/heads/master@{#428359}
==========

[commit-bot: I haz the power, 2016-10-31 20:43:30]

Committed patchset #5 (id:260001)

[commit-bot: I haz the power, 2016-10-31 20:46:15]

Description was changed from

==========
Show the icon for the typed in credit card in editor

BUG=657178

Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Cr-Commit-Position: refs/heads/master@{#428359}
==========

to

==========
Show the icon for the typed in credit card in editor

BUG=657178

Committed: https://crrev.com/7f1a60f6847ee8063df797738a37b9ab299026d5
Committed: https://crrev.com/fdf42fb9c2987cd86ac15e5963af0ad0f0153456
Cr-Original-Commit-Position: refs/heads/master@{#428359}
Cr-Commit-Position: refs/heads/master@{#428797}
==========

[commit-bot: I haz the power, 2016-10-31 20:46:16]

Patchset 5 (id:??) landed as
https://crrev.com/fdf42fb9c2987cd86ac15e5963af0ad0f0153456
Cr-Commit-Position: refs/heads/master@{#428797}