chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java - Issue 2442933003: [Payments] Show the icon for the typed in credit card in editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

Issue 2442933003: [Payments] Show the icon for the typed in credit card in editor (Closed)

Patch Set: fix assertion error and reland Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

index 0fac706861d2a1d9b9edd460691477427df7dc20..ff4061849f4996063ad228e2d85db595bae2a548 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java

@@ -105,7 +105,7 @@ public class ContactEditor extends EditorBase<AutofillContact> {

final EditorFieldModel nameField = mRequestPayerName

? EditorFieldModel.createTextInput(EditorFieldModel.INPUT_TYPE_HINT_PERSON_NAME,

mContext.getString(R.string.payments_name_field_in_contact_details),

- mPayerNames, null,

+ mPayerNames, null, null,

mContext.getString(R.string.payments_field_required_validation_message),

null, contact.getPayerName())

: null;

@@ -113,7 +113,7 @@ public class ContactEditor extends EditorBase<AutofillContact> {

final EditorFieldModel phoneField = mRequestPayerPhone

? EditorFieldModel.createTextInput(EditorFieldModel.INPUT_TYPE_HINT_PHONE,

mContext.getString(R.string.autofill_profile_editor_phone_number),

- mPhoneNumbers, getPhoneValidator(),

+ mPhoneNumbers, getPhoneValidator(), null,

mContext.getString(R.string.payments_field_required_validation_message),

mContext.getString(R.string.payments_phone_invalid_validation_message),

contact.getPayerPhone())

@@ -122,7 +122,7 @@ public class ContactEditor extends EditorBase<AutofillContact> {

final EditorFieldModel emailField = mRequestPayerEmail

? EditorFieldModel.createTextInput(EditorFieldModel.INPUT_TYPE_HINT_EMAIL,

mContext.getString(R.string.autofill_profile_editor_email_address),

- mEmailAddresses, getEmailValidator(),

+ mEmailAddresses, getEmailValidator(), null,

mContext.getString(R.string.payments_field_required_validation_message),

mContext.getString(R.string.payments_email_invalid_validation_message),

contact.getPayerEmail())