Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3382)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 2442933003: [Payments] Show the icon for the typed in credit card in editor (Closed)
Patch Set: fix assertion error and reland Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index 92fac1e7ce28ec55352a66734eba19a96eca3635..2c739bf29ba0a1e651191c1d1e814955af14c6e7 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -496,18 +496,21 @@ void PersonalDataManagerAndroid::UpdateServerCardBillingAddress(
personal_data_manager_->UpdateServerCardBillingAddress(card);
}
-ScopedJavaLocalRef<jstring>
-PersonalDataManagerAndroid::GetBasicCardPaymentTypeIfValid(
+ScopedJavaLocalRef<jstring> PersonalDataManagerAndroid::GetBasicCardPaymentType(
JNIEnv* env,
const JavaParamRef<jobject>& unused_obj,
- const JavaParamRef<jstring>& jcard_number) {
+ const JavaParamRef<jstring>& jcard_number,
+ const jboolean jempty_if_invalid) {
base::string16 card_number = ConvertJavaStringToUTF16(env, jcard_number);
- return ConvertUTF8ToJavaString(
- env, IsValidCreditCardNumber(card_number)
- ? data_util::GetPaymentRequestData(
- CreditCard::GetCreditCardType(card_number))
- .basic_card_payment_type
- : "");
+
+ if (static_cast<bool>(jempty_if_invalid) &&
+ !IsValidCreditCardNumber(card_number)) {
+ return ConvertUTF8ToJavaString(env, "");
+ }
+ return ConvertUTF8ToJavaString(env,
+ data_util::GetPaymentRequestData(
+ CreditCard::GetCreditCardType(card_number))
+ .basic_card_payment_type);
}
void PersonalDataManagerAndroid::AddServerCreditCardForTest(
« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698