[Payments] Show the icon for the typed in credit card in editor

chrome/android/java/res/layout/payments_request_editor_textview.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
 <FrameLayout
     xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
     android:layout_height="wrap_content">
 
     <org.chromium.chrome.browser.widget.CompatibilityTextInputLayout
         android:id="@+id/text_input_layout"
         android:layout_width="match_parent"
         android:layout_height="wrap_content">
 
         <AutoCompleteTextView
             android:id="@+id/text_view"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:singleLine="true"
             android:imeOptions="flagNoExtractUi" />
     </org.chromium.chrome.browser.widget.CompatibilityTextInputLayout>
 
-    <ImageView
-        android:id="@+id/action_icon"
-        android:layout_width="48dp"
-        android:layout_height="48dp"
-        android:padding="12dp"
+    <LinearLayout
+        android:id="@+id/icons_layer"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
         android:layout_gravity="end"
-        android:contentDescription="@null"
-        android:visibility="gone"/>
+        android:orientation="horizontal">
+
+        <ImageView
+            android:id="@+id/value_icon"
+            android:layout_width="37.3dp"

[gone, 2016/10/26 17:22:51]

We don't use a fractional DP anywhere in Clank because it'd make things blurry. 
I've poked the bug about it.

[gogerald1, 2016/10/27 19:01:35]

Keep it according to Hwi@'s feedback

[gone, 2016/10/27 20:14:41]

Her feedback said she was crazy when she set it :P  Set it to 37.

[gogerald1, 2016/10/27 21:52:14]

After talking to Hwi@, the same icon will be used in two places for different
size and it is better to keep it's aspect ratio, so I set the height to 24dp and
auto scales it's width to keep aspect ratio.

+            android:layout_height="24dp"
+            android:layout_marginTop="12dp"
+            android:layout_marginBottom="12dp"

[gone, 2016/10/26 17:22:51]

Instead of setting this margin top and bottom, can't you just set the gravity so
that it's vertically centered?

[gogerald1, 2016/10/27 19:01:35]

Done.

+            android:layout_marginStart="8dp"

[gone, 2016/10/26 17:22:51]

This margin start should be on the parent layout instead because it really
applies to the whole layout and not just this control.

[gogerald1, 2016/10/27 19:01:35]

There might be a future situation that below action icon exist but this icon do
not exist. Then there is already 12dp padding in below icon (for layout and
touch space), we might do not want 8dp additional margin. 

+            android:contentDescription="@null"
+            android:clickable="false"
+            android:visibility="gone"/>
+
+        <ImageView
+            android:id="@+id/action_icon"
+            android:layout_width="48dp"
+            android:layout_height="48dp"
+            android:padding="12dp"
+            android:contentDescription="@null"
+            android:visibility="gone"/>
+    </LinearLayout>
 </FrameLayout>