Percent height content should respect the height of its containing cell

Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
 height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if
they are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

BUG=637811, 627305, 623026, 465096, 468699
Committed: https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f
Cr-Commit-Position: refs/heads/master@{#429109}

[rhogan, 2016-10-24 09:17:37]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 09:17:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 10:33:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 10:33:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rhogan, 2016-10-25 12:44:37]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 12:44:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 13:52:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 13:52:20]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rhogan, 2016-10-31 11:54:52]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 11:54:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 13:30:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 13:30:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rhogan, 2016-10-31 16:51:09]

Description was changed from

==========
Percent height content should respect the height of its containing cell

BUG=637811,627305,623026,465096,468699
==========

to

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

BUG=637811,627305,623026,465096,468699
==========

[rhogan, 2016-10-31 16:53:00]

Description was changed from

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

BUG=637811,627305,623026,465096,468699
==========

to

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if they
are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

 stored on 
BUG=637811,627305,623026,465096,468699
==========

[rhogan, 2016-10-31 16:53:16]

Description was changed from

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if they
are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

 stored on 
BUG=637811,627305,623026,465096,468699
==========

to

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
 height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if
they are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

 stored on 
BUG=637811,627305,623026,465096,468699
==========

[rhogan, 2016-10-31 16:53:28]

Description was changed from

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
 height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if
they are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

 stored on 
BUG=637811,627305,623026,465096,468699
==========

to

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
 height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if
they are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

BUG=637811,627305,623026,465096,468699
==========

[rhogan, 2016-10-31 16:54:03]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org, mstensho@opera.com

[eae, 2016-10-31 17:05:40]

Very nice! LGTM

[rhogan, 2016-11-01 19:45:08]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-11-01 19:45:09]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2441373002/#ps60001
(title: "bug 637811")

[commit-bot: I haz the power, 2016-11-01 19:45:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 21:08:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-01 21:10:38]

Description was changed from

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
 height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if
they are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

BUG=637811,627305,623026,465096,468699
==========

to

==========
Percent height content should respect the height of its containing cell

Another go at the collection of CLs reverted in
https://codereview.chromium.org/2309893002.

https://drafts.csswg.org/css-tables-3/#row-layout now says:

"For the purpose of calculating this height, descendants of table cells whose
 height depends on percentages of their parent cell' height are considered to
have an auto height if they have overflow set to *visible or hidden* or if
they are replaced elements, and a 0px height if they have not."

So introduce that behaviour. We also need to account for intrinsic padding and
collapsed border values stored on cells when collecting their border and padding
values.

BUG=637811,627305,623026,465096,468699

Committed: https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f
Cr-Commit-Position: refs/heads/master@{#429109}
==========

[commit-bot: I haz the power, 2016-11-01 21:10:39]

Patchset 4 (id:??) landed as
https://crrev.com/b5243ab8c1a95305aff233a6175aa3a1f94d092f
Cr-Commit-Position: refs/heads/master@{#429109}