Percent height content should respect the height of its containing cell

third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
@@ skipping 1096 matching lines @@
                                             totalPercent);
   distributeExtraLogicalHeightToAutoRows(remainingExtraLogicalHeight,
                                          autoRowsCount);
   distributeRemainingExtraLogicalHeight(remainingExtraLogicalHeight);
   return extraLogicalHeight - remainingExtraLogicalHeight;
 }
 
 static bool shouldFlexCellChild(LayoutObject* cellDescendant) {
   return cellDescendant->isAtomicInlineLevel() ||
          (cellDescendant->isBox() &&
-          toLayoutBox(cellDescendant)->scrollsOverflow());
+          toLayoutBox(cellDescendant)->style()->overflowY() !=
+              OverflowVisible &&
+          toLayoutBox(cellDescendant)->style()->overflowY() != OverflowHidden);
 }
 
 void LayoutTableSection::layoutRows() {
 #if ENABLE(ASSERT)
   SetLayoutNeededForbiddenScope layoutForbiddenScope(*this);
 #endif
 
   ASSERT(!needsLayout());
 
   LayoutAnalyzer::Scope analyzer(*this);
@@ skipping 761 matching lines @@
   // do, but it will clip the cells that spill out of the table section.
   // strict mode, Mozilla and WinIE both regrow the table to accommodate the
   // new height of the cell (thus letting the percentages cause growth one
   // time only). We may also not be handling row-spanning cells correctly.
   //
   // Note also the oddity where replaced elements always flex, and yet blocks/
   // tables do not necessarily flex. WinIE is crazy and inconsistent, and we
   // can't hope to match the behavior perfectly, but we'll continue to refine it
   // as we discover new bugs. :)
   bool cellChildrenFlex = false;
-  bool flexAllChildren = cell.style()->logicalHeight().isFixed() ||
+  bool flexAllChildren = cell.style()->logicalHeight().isSpecified() ||
                          (!table()->style()->logicalHeight().isAuto() &&
                           rowHeight != cell.logicalHeight());
 
   for (LayoutObject* child = cell.firstChild(); child;
        child = child->nextSibling()) {
     if (!child->isText() && child->style()->logicalHeight().isPercentOrCalc() &&
         (flexAllChildren || shouldFlexCellChild(child)) &&
         (!child->isTable() || toLayoutTable(child)->hasSections())) {
       cellChildrenFlex = true;
       break;
@@ skipping 168 matching lines @@
   // the header in all columns.
   // Note that this is in flow thread coordinates, not visual coordinates. The
   // enclosing LayoutFlowThread will convert to visual coordinates.
   if (table()->header() == this && isRepeatingHeaderGroup())
     rect.setHeight(table()->logicalHeight());
   return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect,
                                                                  flags);
 }
 
 }  // namespace blink