Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2441373002: Percent height content should respect the height of its containing cell (Closed)
Patch Set: bug 637811 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
index 48612f65b6bfb2ac0c6ff3a2e7b15a7409facd76..ba4d420c240d4e39ba3fd2d70c483442f37a6b26 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
@@ -1114,7 +1114,9 @@ int LayoutTableSection::distributeExtraLogicalHeightToRows(
static bool shouldFlexCellChild(LayoutObject* cellDescendant) {
return cellDescendant->isAtomicInlineLevel() ||
(cellDescendant->isBox() &&
- toLayoutBox(cellDescendant)->scrollsOverflow());
+ toLayoutBox(cellDescendant)->style()->overflowY() !=
+ OverflowVisible &&
+ toLayoutBox(cellDescendant)->style()->overflowY() != OverflowHidden);
}
void LayoutTableSection::layoutRows() {
@@ -1896,7 +1898,7 @@ void LayoutTableSection::relayoutCellIfFlexed(LayoutTableCell& cell,
// can't hope to match the behavior perfectly, but we'll continue to refine it
// as we discover new bugs. :)
bool cellChildrenFlex = false;
- bool flexAllChildren = cell.style()->logicalHeight().isFixed() ||
+ bool flexAllChildren = cell.style()->logicalHeight().isSpecified() ||
(!table()->style()->logicalHeight().isAuto() &&
rowHeight != cell.logicalHeight());
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698